Move dependency on extended_email_reply_parser into the Conversations gem
#999
Comments
jagthedrummer
added a commit
that referenced
this issue
Dec 30, 2024
For some reason `extended_email_reply_parser` was added as a dependency to the main `bullet_train` gem even though it's not used anywhere in `core` or in the starter repo. It _is_ used by `bullet_train-conversations` and is declared as a dependency there, so we don't need it here. `extended_email_reply_parser` relies on `charlock_holmes` which is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train. Fixes #999
jagthedrummer
added a commit
that referenced
this issue
Dec 30, 2024
For some reason `extended_email_reply_parser` was added as a dependency to the main `bullet_train` gem even though it's not used anywhere in `core` or in the starter repo. It _is_ used by `bullet_train-conversations` and is declared as a dependency there, so we don't need it here. `extended_email_reply_parser` relies on `charlock_holmes` which is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train. Fixes #999
jagthedrummer
added a commit
that referenced
this issue
Dec 30, 2024
* Remove `extended_email_reply_parser` dependency For some reason `extended_email_reply_parser` was added as a dependency to the main `bullet_train` gem even though it's not used anywhere in `core` or in the starter repo. It _is_ used by `bullet_train-conversations` and is declared as a dependency there, so we don't need it here. `extended_email_reply_parser` relies on `charlock_holmes` which is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train. Fixes #999 * Oops missed one * Need to define another teplate method * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For some reason
extended_email_reply_parseris listed as a dependency on the mainbullet_traingem, but it's not actually used anywhere incoreor the starter repo. It seems like it was added to make the conversations gem work, but I'm not sure why it was added tobullet_trainand not that gem.extended_email_reply_parserdepends oncharlock_holmeswhich is very finicky to install due to native dependencies. Lots (possibly a majority?) of the problems that people run into getting Bullet Train running have to do with installingcharlock_holmes. Removing it as a dependency incoreshould make things easier for people just starting out.The text was updated successfully, but these errors were encountered: