Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove setup process for icu4c? #1849

Open
jagthedrummer opened this issue Dec 30, 2024 · 0 comments
Open

Can we remove setup process for icu4c? #1849

jagthedrummer opened this issue Dec 30, 2024 · 0 comments

Comments

@jagthedrummer
Copy link
Contributor

This is a native dependency needed by charlock_holmes, but as of bullet-train-co/bullet_train-core#1002 we don't require charlock_holmes by default.

That's a gem that's just needed by bullet_train-conversations and it does nothing but cause problems in a fresh BT app.

We can probably remove the bits of the configure/setup scripts that look for icu4c, though we'll want to add some details to the README for the bullet_train-conversations gem that help people get it installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant