Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tracking: Disabled tests #5389

Closed
6 of 21 tasks
bbondy opened this issue Nov 4, 2016 · 2 comments
Closed
6 of 21 tasks

Tracking: Disabled tests #5389

bbondy opened this issue Nov 4, 2016 · 2 comments
Assignees
Labels
automated-tests needs-info Another team member needs information from the PR/issue opener. project-tracking

Comments

@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

Overview:

This issue tracks the disabled tests. It should always appear in the current milestone so that it's a constant reminder for us to work at re-enabling them. This will help us get green so we can better determine when to merge and when not to merge things.

Other info:

  • If a test is failing, the code that introduced it should be backed out if the test can’t be fixed right away.
  • If a test is failing intermittently, it should be added to this list. If it is newly intermittent, the task that introduced it should be backed out if it can be determined.
  • Everyone should try to get all of these tests below down to 0.
  • When a test is fixed check it off and move it to the fixed intermittents section.

Disabled tests:

  • findBar findbar input remembered but no active ordinals after navigation until RETURN key:
    test/about/componentUpdaterTest.js
    test/components/findbarTest.js
    more info: Disabled for Find in page doesn't work correctly after navigation if 0 results #6147
    AssertionError: '0 matches' == '1 of 1'
    expected - actual
    -0 matches
    +1 of 1

  • Google Widevine can be enabled and installed
    test/about/componentUpdaterTest.js
    more info: This is only disabled on Linux and it's because the feature is not available there yet.

  • should attempt a reload when reload is clicked
    test/components/errorPageTest.js
    more info: need a better way to test this

  • Limit effect of running insecure content in private frame
    test/components/navigationBarTest.js
    more info: Unknown.
    Owner: @darkdh

  • Parses theme-color meta tag when one is present
    test/components/navigationBarTest.js
    more info: Unknown
    Owner: @bbondy

  • Obtains theme color from the background
    test/components/navigationBarTest.js
    more info: Unknown
    Owner: @bbondy

  • Obtains theme color from a top header and not background
    test/components/navigationBarTest.js
    more info: Unknown
    Owner: @bbondy

  • focuses the opener
    test/components/windowTest.js
    more info: Unknown

  • blurs the opener
    test/components/windowTest.js
    more info: Unknown

  • setting observer unit test
    test/unit/app/browser/settingObserverTest.js
    more info: I think this can just be removed along with the code since I don't think it's used. Needs to grep for the module though to be sure.

  • passes NIST Test Case 13
    test/unit/lib/cryptoUtilTest.js
    more info: fails with Error: Unsupported state or unable to authenticate data

  • homepage displays punycode
    test/about/preferencesTest.js
    Since: Nov 4. 2016
    more info: Seems to consistently fail on Travis
    Owner: @diracdeltas

  • does not show faked page title
    test/components/navigationBarTest.js
    Since: Nov 4. 2016
    more info: Seems to consistently fail on Travis
    Owner: @diracdeltas

  • Closing pinned tabs
    test/components/pinnedTabTest.js
    Since: Nov 24 2016
    more info: Fails intermittently
    Owner: @bbondy

  • change tabs
    test/components/navigationBarTest.js
    Since: January 5, 2017
    Owner: @bbondy

  • Credit card auto fill
    test/contents/autofillTest.js
    Since: Mar 30, 2017
    more info: This was disabled because credit card works only when connection is https and local host is only http
    Owner: @darkdh
    fixed in Re-enable https test #9375

  • shows a context menu when long pressed (click and hold)
    test/tab-components/tabTest.js
    Since: April 20, 2017
    more info: Does not work with a native context menu.

  • shows a context menu when right clicked
    test/tab-components/tabTest.js
    Since: April 20, 2017
    more info: Does not work with a native context menu.

  • notificationBar passwords
    test/bravery-components/notificationBarTest.js
    Since: May 16, 2017
    more info: chromium password manager requires https to prompt users to save password or autofill for them
    Owner: @darkdh
    fixed in Re-enable https test #9375

  • advanced payment panel tests
    test/about/ledgerPanelAdvancedPanelTest.js
    Since: Jul 27, 2017
    more info: can be re-enabled when Saving wallet backup keys is not loading the page #9677 is fixed

  • Ledger table 2 publishers check pinned sites amount, when you have 0 eligible unpinned sites
    test/about/ledgerTableTest.js
    Since: Jul 27, 2017
    more info: can be re-enabled when Ledger pin publishers 0 for unpinned sites #9641 is fixed

Fixed intermittents:

@bbondy bbondy added this to the 0.12.8dev milestone Nov 4, 2016
bbondy added a commit that referenced this issue Nov 5, 2016
bbondy added a commit that referenced this issue Nov 7, 2016
Various urlbar fixes

- When cutting a URL it will not revert the user input to the original
  URL.  Fix #5063
- Fix URL sometimes getting appended. Some automated tests were
  failing with exactly that problem.  Fix #5036
- Fix various navigationBar tests. Fix #5459
- This might Fix #5444. Please re-open if not.
- Clicking in the navigation bar was only selecting part of the URL
  sometimes and it should select all. Fix #5460
- One failing automated test was disabled, it seems to be failing for
  something related to windowByIndex though and doesn't seem to be a
  problem.  It was already failing before too.  It was documented here:
  #5389

Auditors: @diracdeltas
@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Nov 7, 2016
bbondy added a commit that referenced this issue Nov 11, 2016
bbondy added a commit that referenced this issue Nov 12, 2016
Follow up tweak for #5389

The fix for the JS error in 83eccb5 actually introduced some test failures because that JS error was saving this code from getting hit.  This makes the tests pass and is more logical, if the prevState is selected and the current state it not selected, we don't want to select

Auditors: @diracdeltas
@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Jan 19, 2017
@alexwykoff alexwykoff modified the milestones: 0.13.3, 0.13.2 Feb 6, 2017
@bbondy bbondy modified the milestones: 0.13.4, 0.13.3 Feb 15, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 28, 2017
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
44 tasks
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 21, 2017
@bbondy bbondy modified the milestones: 0.14.3, 0.14.2 Apr 11, 2017
@alexwykoff alexwykoff self-assigned this Apr 18, 2017
@bbondy bbondy modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 6, 2017
@alexwykoff alexwykoff modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Jul 18, 2017
@alexwykoff alexwykoff removed this from the 0.20.x (Developer Channel) milestone Aug 8, 2017
@alexwykoff
Copy link
Contributor

we have this tracked in source control and in chat

@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2017

Is it surely ok to close this?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automated-tests needs-info Another team member needs information from the PR/issue opener. project-tracking
Projects
None yet
Development

No branches or pull requests

4 participants