Find in page doesn't work correctly after navigation if 0 results

[bbondy]

This works in 0.12.14
This fails in 0.13.0

Run this test:

npm run test -- --grep="findbar input remembered"

It fails for a legit reason. You can reproduce as follows manually:

Start an http server in the browser-laptop test dir

1. cd test/fixtures
2. python -m SimpleHTTPServer 9099
3. Load http://localhost:9099/find_in_page.html
4. Open find bar and type Brad
5. Load http://localhost:9099/find_in_page2.html
6. Open find bar and press enter

It doesn’t find the match

It should find the match

[cndouglas]

I think I can reproduce this issue on both 0.12.14 and master. The only change (in 0.13.0) I can think of is my PR #5786 (commit 29e7d53) that changed the findbar's onKeyUp to onInput.

[cezaraugusto]

@liunkae your commit isn't added yet on the latest release (v0.13.0dev-Preview2). See here.

[bbondy]

I confirmed it wasn't because of your change @liunkae by the way by reverting it and testing.

[bbondy]

I think I tested wrong before this seems to have always been a problem, or at least for the last couple releases.

[bbondy]

Disabling the test for now #5389