Saving wallet backup keys is not loading the page

[NejcZdovc]

• Did you search for similar issues before submitting this one?
  yes

• Describe the issue you encountered:
  files are not opened correctly

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version (revision SHA):
  705b4e4

• Steps to reproduce:

  1. Go to payment and enable it
  2. Click on gear icon
  3. Click backup ledger keys
  4. Download keys
  5. New tab is opened

• Actual result:
  Infinite loading

• Expected result:
  File is loaded

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  yes

• Is this an issue in the currently released version?
  no

• Can this issue be consistently reproduced?
  ye

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:

[NejcZdovc]

I think this is a problem with muon, because this logic was not changed and we are calling webContents directly https://github.com/brave/browser-laptop/blob/master/app/ledger.js#L376. On this line we get correct file url.

If I comment out this line tab is displayed correctly, but of course download doesn't start.

[bridiver]

that method should be checking to see if webContents is null. Without that check (and the second error param) it's hard to know what the problem is

[bridiver]

actually the usage there doesn't make sense. If we are opening the tab with the file url there is no reason to call downloadURL and it might be breaking now because the download behavior was fixed here f86a8a4

[NejcZdovc]

yeah this could be the case, nice find

[NejcZdovc]

Ok, we need to rework it then

[NejcZdovc]

Revert #10167 when this is fixed

[alexwykoff]

@NejcZdovc when you have a moment please give this another spin

[NejcZdovc]

this is still a problem, we get crashed tab, so you can't close it or select it

[NejcZdovc]

+1 from #12221

[NejcZdovc]

fixed with #13279

[srirambv]

Verified on Windows x64

• 0.22.6 e6ff4ea
• libchromiumcontent: 65.0.3325.162
• muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.6 e6ff4ea
• libchromiumcontent: 65.0.3325.162
• muon: 5.1.0

Verified on Ubuntu 10.10 x64

• 0.22.7 8bb7e77
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.1