Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily revert U2F sig check for Ledger U2F transport support" #9081

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 10, 2021

Fix brave/brave-browser#16205

Reverts #8995
That is to say reverts a C91 patch which removed a check for valid U2F communication.

This should only land on each channel after #9061 and a Crypto Wallets 1.0.29 is released + some buffer of days.

FYI @fmarier @diracdeltas as an FYI that the temporary workaround was actually temporary :)

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from mkarolin June 10, 2021 14:23
@bbondy bbondy self-assigned this Jun 10, 2021
@bbondy bbondy requested a review from a team as a code owner June 10, 2021 14:23
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy force-pushed the revert-8995-U2F-transport branch from dd2aaf2 to f9f22d4 Compare June 28, 2021 15:12
@bbondy bbondy merged commit 4816116 into master Jun 28, 2021
@bbondy bbondy deleted the revert-8995-U2F-transport branch June 28, 2021 18:20
@bbondy bbondy added this to the 1.28.x - Nightly milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert: Temporarily revert U2F sig check for Ledger U2F transport support
2 participants