-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow chrome.hid for Crypto Wallets extension #9061
Conversation
Probably a dumb question - where did you get the |
You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patches
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enables these two extensions APIs:
hid
usbDevices
"channel": "stable", | ||
"extension_types": ["extension"], | ||
"allowlist": [ | ||
+ "21070F3D60711361C1210B870439BE49B5D995F4", // Ethereum Remote Client extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should have gone in https://github.com/brave/brave-core/blob/master/common/extensions/api/_permission_features.json or better yet we should dump the existing patch in feature_compiler.py and do a chromium_src override for AddCorePermissionFeatures
in the permission_features.h generated file
Resolves brave/brave-browser#16305
Description of the fix in the issue.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: