-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose chrome.hid to Crypto Wallets extension #16305
Comments
@bbondy I don't think this is working. I tried it on
Same results on
Once we get the |
Verification PASSED on
Verification PASSED on
Verification PASSED on
|
Crypto Wallets extension used to use U2F via a metamask.io page.
In Chromium 91 this changed to add a security check which we reverted temporarily in #16204
We'd like to revert the C91 patch after this issue is released which is tracked here:
#16205
Before we revert the C91 patch we need this to be on Release channel so that people that use Crypto Wallets with U2F won't break.
Code for using the new HID API is here:
brave/ethereum-remote-client#243
and here: brave/eth-ledger-bridge-keyring@6db82c1
This issue is to track just allow the extension to use chrome.hid though.
Test plan
--use-dev-goupdater-url
and pullCrypto Wallets 1.0.30
Release notes title can be something like: Support Ledger devices in Crypto Wallets via HID transport.
The text was updated successfully, but these errors were encountered: