-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily revert U2F sig check for Ledger U2F transport support #16204
Labels
Milestone
Comments
bbondy
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Jun 2, 2021
bbondy
added a commit
to brave/brave-core
that referenced
this issue
Jun 2, 2021
Issue to revert the Chromium code here: brave/brave-browser#16204 Issue to revert the revert here: brave/brave-browser#16205 Issue to implement webhid for our wallet here: brave/brave-browser#16206
24 tasks
Re-opening until it's landed on 1.25.x |
@bbondy assuming the following STR/Cases are sufficient enough?
Anything else that QA should run through? |
Verification passed on
Verification passed on
Verification partially passed on
|
22 tasks
srirambv
added
feature/ethereum-remote-client
and removed
feature/web3/wallet
Integrating Ethereum+ wallet support
labels
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chromium/chromium@07ef8d7 breaks the U2F support of Ledger.
This is a problem with the transport being used to send arbitrary data, our wallet and other wallets still use the Ledger U2F transport though. So this issue is to track a temporary revert as we work out how to communicate over webhid instead.
The text was updated successfully, but these errors were encountered: