Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert U2F sig check for Ledger U2F transport support #8995

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 2, 2021

Resolves brave/brave-browser#16204

This is tracking a partial revert of this patch chromium/chromium@07ef8d7
which makes the U2F transport more strict. It breaks Ledger support.
We're going to move our ledger compatibility to webhid instead, but this will buy us time to do that.
See the above Slack links for an internal discussion on this.

Issue to revert the revert here:
brave/brave-browser#16205

Issue to implement webhid for our wallet here:
brave/brave-browser#16206

Submitter Checklist:

https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1622653482048200?thread_ts=1622102662.023400&cid=CBP2ZKC0H

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Issue to revert the Chromium code here:
brave/brave-browser#16204

Issue to revert the revert here:
brave/brave-browser#16205

Issue to implement webhid for our wallet here:
brave/brave-browser#16206
@bbondy bbondy requested a review from a team as a code owner June 2, 2021 17:44
@bbondy bbondy self-assigned this Jun 2, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are temporary, ok with patches as they are. ++

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as a temporary work-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily revert U2F sig check for Ledger U2F transport support
3 participants