Temporarily revert U2F sig check for Ledger U2F transport support #8995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16204
This is tracking a partial revert of this patch chromium/chromium@07ef8d7
which makes the U2F transport more strict. It breaks Ledger support.
We're going to move our ledger compatibility to webhid instead, but this will buy us time to do that.
See the above Slack links for an internal discussion on this.
Issue to revert the revert here:
brave/brave-browser#16205
Issue to implement webhid for our wallet here:
brave/brave-browser#16206
Submitter Checklist:
https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1622651391047000?thread_ts=1622102662.023400&cid=CBP2ZKC0H
https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1622653482048200?thread_ts=1622102662.023400&cid=CBP2ZKC0H
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: