Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dapp detection, crypto wallets infobar #7321

Closed
wants to merge 1 commit into from
Closed

Removing dapp detection, crypto wallets infobar #7321

wants to merge 1 commit into from

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 3, 2020 •
edited
Loading

Fixes brave/brave-browser#13009

Closes:
brave/brave-browser#12942
brave/brave-browser#12709
brave/brave-browser#6491

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Defined in root issue

@ryanml ryanml added this to the 1.20.x - Nightly milestone Dec 3, 2020
@ryanml ryanml requested review from marshall and bbondy December 3, 2020 00:07
@ryanml ryanml requested a review from a team as a code owner December 3, 2020 00:07
@ryanml ryanml self-assigned this Dec 3, 2020
@ryanml ryanml force-pushed the remove-dapp-detect branch from 727c3f3 to 63936a1 Compare December 3, 2020 00:23
bbondy
bbondy requested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to remove the lazy loading too. Otherwise upon restart it won't be loaded at all.

components/brave_wallet/brave_wallet_constants.h Outdated Show resolved Hide resolved
@ryanml ryanml mentioned this pull request Dec 7, 2020
Closed
@ryanml ryanml force-pushed the remove-dapp-detect branch from 63936a1 to 80b922f Compare January 8, 2021 19:50
@ryanml ryanml requested a review from bbondy January 8, 2021 19:51
@ryanml
Copy link
Contributor Author

ryanml commented Jan 8, 2021

Rebased, will confirm restart behavior

@ryanml ryanml force-pushed the remove-dapp-detect branch from 80b922f to c449985 Compare January 18, 2021 21:14
@ryanml
Copy link
Contributor Author

ryanml commented Jan 18, 2021

Rebased, functionality looks good, would love to have a second pair of eyes spot check a PR build when they're ready

@bbondy bbondy mentioned this pull request Feb 7, 2021
Closed
@bbondy
Copy link
Member

bbondy commented Feb 7, 2021

I think we're going to go this route instead:
brave/brave-browser#14018 so I think this can be closed.

@bbondy bbondy closed this Feb 7, 2021
@diracdeltas diracdeltas mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshall marshall Awaiting requested review from marshall

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@ryanml ryanml

Labels
feature/eth-wallet
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.

Dapp detection, Crypto Wallets infobar, should be removed.
2 participants
@ryanml @bbondy