-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dApp detection for nytimes.com #12709
Labels
Milestone
Comments
srirambv
added
feature/web3/wallet
Integrating Ethereum+ wallet support
QA/Yes
release-notes/include
labels
Nov 16, 2020
dupe of #12482? |
cc: @marshall |
23 tasks
bbondy
changed the title
Improve dApp detection so that it's not triggered on nytimes.com (New York Times)
Remove dApp detection for nytimes.com and calendar.google.com
Dec 4, 2020
23 tasks
bbondy
changed the title
Remove dApp detection for nytimes.com and calendar.google.com
Remove dApp detection for nytimes.com
Dec 4, 2020
|
Verification passed on
Verified test plan from the description Verification passed on
Verified test plan from the description |
srirambv
added
feature/ethereum-remote-client
and removed
feature/web3/wallet
Integrating Ethereum+ wallet support
labels
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Users are being prompted for Crypto Wallet on the New York Times website (https://nytimes.com). Issue is similar to #11865 (which dealt with archive.org).
Steps to Reproduce
Expected result:
No Crypto Wallets bar should appear.
Actual result:
The Crypto Wallets bar appears.
Reproduces how often:
Very easily. Reproduced on first try on Version 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64), MacOS.
Brave version (brave://version info)
Version 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64)
Also reproduced on Version 1.18.51 Chromium: 87.0.4280.49 (Official Build) beta (x86_64)
The text was updated successfully, but these errors were encountered: