Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dApp detection for nytimes.com #12709

Closed
Miyayes opened this issue Nov 15, 2020 · 4 comments · Fixed by brave/brave-core#7342
Closed

Remove dApp detection for nytimes.com #12709

Miyayes opened this issue Nov 15, 2020 · 4 comments · Fixed by brave/brave-core#7342

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 15, 2020

Description

Users are being prompted for Crypto Wallet on the New York Times website (https://nytimes.com). Issue is similar to #11865 (which dealt with archive.org).

Steps to Reproduce

  1. Navigate to https://nytimes.com, you need to be signed up for an account. @diracdeltas has an account.

Expected result:

No Crypto Wallets bar should appear.

Actual result:

The Crypto Wallets bar appears.

Reproduces how often:

Very easily. Reproduced on first try on Version 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64), MacOS.

Brave version (brave://version info)

Version 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64)

Also reproduced on Version 1.18.51 Chromium: 87.0.4280.49 (Official Build) beta (x86_64)

@rebron
Copy link
Collaborator

rebron commented Nov 16, 2020

dupe of #12482?

@bsclifton
Copy link
Member

cc: @marshall

@ryanml ryanml self-assigned this Dec 3, 2020
@bbondy bbondy changed the title Improve dApp detection so that it's not triggered on nytimes.com (New York Times) Remove dApp detection for nytimes.com and calendar.google.com Dec 4, 2020
@bbondy bbondy added this to the 1.20.x - Nightly milestone Dec 4, 2020
@bbondy bbondy changed the title Remove dApp detection for nytimes.com and calendar.google.com Remove dApp detection for nytimes.com Dec 4, 2020
@bbondy bbondy assigned bbondy and unassigned ryanml Dec 4, 2020
@btlechowski
Copy link

QA/Blocked till we get a new build (> 1.18.69)

@btlechowski
Copy link

btlechowski commented Dec 9, 2020

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description
Crypto wallet bar is not shown

image


Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Crypto wallet bar is not shown

image

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment