Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Dapp detection but only for greaselion sites #14018

Closed
bbondy opened this issue Feb 7, 2021 · 1 comment
Closed

Keep Dapp detection but only for greaselion sites #14018

bbondy opened this issue Feb 7, 2021 · 1 comment
Labels
closed/duplicate Issue has already been reported feature/ethereum-remote-client OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@bbondy
Copy link
Member

bbondy commented Feb 7, 2021

We thought of removing Dapp detection completely, but I think it's still useful. It has some false positives currently where we show the infobar which is not good.

We could instead use Greaselion to show the Crypto Wallets infobar for a whitelist of sites.
It'd be ok if we don't show it for sites, it's just an onboarding mechanism though that we can use for popular Dapps to help users that would want to use those Dapps.

See this for relevant code sections:

yeah, greaselion side looks like this: https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/youtube/publisherInfo.ts#L204-L226

brave extension handler is here: https://github.com/brave/brave-core/blob/502215e0dbbbe0f1a09de9325f95c18b84eeec5c/components/brave_extension/extension/brave_extension/background/greaselion.ts#L327-L421

This will supersede this work:
brave/brave-core#7321

As part of this work, we'll have to get rid of the lazy loading.

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Feb 7, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 7, 2021
@bbondy bbondy removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 7, 2021
@bbondy bbondy added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 14, 2021
@bbondy
Copy link
Member Author

bbondy commented Sep 22, 2021

superseded by #18213

@bbondy bbondy closed this as completed Sep 22, 2021
@bbondy bbondy added the closed/duplicate Issue has already been reported label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/ethereum-remote-client OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

1 participant