Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ask for download location setting in Private windows. #18290

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#29823

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested review from goodov and simonhong April 28, 2023 02:55
@mkarolin mkarolin self-assigned this Apr 28, 2023
@mkarolin mkarolin force-pushed the maxk-fix-private-ask-download-location branch from 750b900 to 7514977 Compare April 28, 2023 22:56
@mkarolin
Copy link
Collaborator Author

Rebased on master.

@mkarolin
Copy link
Collaborator Author

P3ARotationSchedulerTest.JsonRotation failed on MacOS - unrelated to this PR.

@mkarolin mkarolin marked this pull request as ready for review April 29, 2023 02:00
@mkarolin mkarolin requested a review from a team as a code owner April 29, 2023 02:00
@mkarolin mkarolin merged commit 4fb7c81 into master Apr 29, 2023
@mkarolin mkarolin deleted the maxk-fix-private-ask-download-location branch April 29, 2023 02:00
@mkarolin mkarolin added this to the 1.53.x - Nightly milestone Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private window doesn't respect "Ask where to save each file before downloading" option.
3 participants