Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private window doesn't respect "Ask where to save each file before downloading" option. #29823

Closed
mkarolin opened this issue Apr 18, 2023 · 4 comments · Fixed by brave/brave-core#18290
Closed

Private window doesn't respect "Ask where to save each file before downloading" option. #29823

mkarolin opened this issue Apr 18, 2023 · 4 comments · Fixed by brave/brave-core#18290
Assignees
@mkarolin
Labels
bug OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 18, 2023 •
edited
Loading

Based on the comment #28562 (comment)

Reproduced with 1.52.51

STR:

  1. Start Brave
  2. Navigate to brave://settings/downloads
  3. Toggle the Ask where to save each file before downloading setting to off
  4. Paste a file download link (e.g. http://ipv4.download.thinkbroadband.com:8080/1GB.zip) into the location bar and press
  5. Click "Continue to site" on the "Connection is not secure" page
  6. Observe: the download starts without asking where to save the file (the download progress bubble is shown)
  7. Open a Private window
  8. Repeat steps 4-5

Actual result:

  • Save File dialog is shown

Expected result:

  • Save File dialog is NOT shown
  • The download starts (the download progress bubble is shown)

NOTE: Also reproducible in Chrome (113.0.5672.35).
@mkarolin mkarolin mentioned this issue Apr 18, 2023
Closed
@mkarolin
Copy link
Contributor Author

Upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1381219

@mkarolin mkarolin mentioned this issue Apr 28, 2023
Merged
25 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Apr 28, 2023
@mkarolin
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload…
29f828b 
… on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.
mkarolin added a commit to brave/brave-core that referenced this issue Apr 28, 2023
@mkarolin
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload…
3fc5428 
… on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.
mkarolin added a commit to brave/brave-core that referenced this issue Apr 28, 2023
@mkarolin
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload…
3c2e47b 
… on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.
kjozwiak pushed a commit to brave/brave-core that referenced this issue Apr 28, 2023
@mkarolin @brave-builds
Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.52.x…
fb1d285 
…). (#18270)

* Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

* Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

* Update pins list timestamp

* Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.

---------

Co-authored-by: brave-builds <brave-builds+devops@brave.com>
kjozwiak pushed a commit to brave/brave-core that referenced this issue Apr 28, 2023
@mkarolin @brave-builds
Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x…
ce813ef 
…). (#18269)

* Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

* Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

* Update pins list timestamp

* Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.

---------

Co-authored-by: brave-builds <brave-builds+devops@brave.com>
muliswilliam added a commit to brave/brave-core that referenced this issue Apr 28, 2023
@muliswilliam
Hide network icon
9435d74 
commit c98ff5e
Author: brave-builds <brave-builds+devops@brave.com>
Date:   Fri Apr 28 08:29:10 2023 +0000

    1.51.107

commit ce813ef
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 04:25:41 2023 -0400

    Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269)

    * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Update pins list timestamp

    * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

    The test fails because in Chromium Private/Incognito profiles now ignore the
    "Ask for download location" setting and always prompt for the location.
    We will fix that in brave/brave-browser#29823,
    but until then let's disable this test on MacOS.

    ---------

    Co-authored-by: brave-builds <brave-builds+devops@brave.com>

commit b18aeae
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 10:15:10 2023 +0200

    Disable site affiliation fetcher (uplift to 1.51.x) (#18286)

    Uplift of #18153 (squashed) to release

commit 6b1db58
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:47:20 2023 +0200

    Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228)

    Uplift of #18172 (squashed) to beta

commit f7f8042
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:42:41 2023 +0200

    Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263)

    Uplift of #18154 (squashed) to beta

commit 545fa57
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 03:07:51 2023 -0400

    Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264)

    Don't call GetSessionRoute() when media router is disabled (#18245)

    Otherwise, it would end in reaching NOTREACHED()

    Co-authored-by: Sangwoo Ko <sko@brave.com>

commit 0fbe592
Author: Arthur Edelstein <aedelstein@brave.com>
Date:   Thu Apr 27 17:44:23 2023 -0700

    Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179)

    * Migrate to HttpsFirstMode v2 (#17856)

    Migrate HTTPS by Default feature to use HttpsFirstMode v2

    * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141)

commit e369d71
Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com>
Date:   Fri Apr 28 03:34:51 2023 +0700

    Disable flaky upstream tests. (Uplift to 1.51.x) (#18274)

Update nft-details.tsx
@mkarolin mkarolin self-assigned this Apr 29, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone Apr 29, 2023
kjozwiak pushed a commit to brave/brave-core that referenced this issue May 1, 2023
@muliswilliam
fix(wallet): Hide network icon in NFT Details (#18296)
3c8f885 
Hide network icon

commit c98ff5e
Author: brave-builds <brave-builds+devops@brave.com>
Date:   Fri Apr 28 08:29:10 2023 +0000

    1.51.107

commit ce813ef
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 04:25:41 2023 -0400

    Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269)

    * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Update pins list timestamp

    * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

    The test fails because in Chromium Private/Incognito profiles now ignore the
    "Ask for download location" setting and always prompt for the location.
    We will fix that in brave/brave-browser#29823,
    but until then let's disable this test on MacOS.

    ---------

    Co-authored-by: brave-builds <brave-builds+devops@brave.com>

commit b18aeae
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 10:15:10 2023 +0200

    Disable site affiliation fetcher (uplift to 1.51.x) (#18286)

    Uplift of #18153 (squashed) to release

commit 6b1db58
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:47:20 2023 +0200

    Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228)

    Uplift of #18172 (squashed) to beta

commit f7f8042
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:42:41 2023 +0200

    Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263)

    Uplift of #18154 (squashed) to beta

commit 545fa57
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 03:07:51 2023 -0400

    Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264)

    Don't call GetSessionRoute() when media router is disabled (#18245)

    Otherwise, it would end in reaching NOTREACHED()

    Co-authored-by: Sangwoo Ko <sko@brave.com>

commit 0fbe592
Author: Arthur Edelstein <aedelstein@brave.com>
Date:   Thu Apr 27 17:44:23 2023 -0700

    Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179)

    * Migrate to HttpsFirstMode v2 (#17856)

    Migrate HTTPS by Default feature to use HttpsFirstMode v2

    * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141)

commit e369d71
Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com>
Date:   Fri Apr 28 03:34:51 2023 +0700

    Disable flaky upstream tests. (Uplift to 1.51.x) (#18274)

Update nft-details.tsx
@stephendonner
Copy link

Verified PASSED using

Brave 1.53.67 Chromium: 114.0.5735.53 (Official Build) beta (x86_64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS macOS Version 11.7.7 (Build 20G1345)

Followed the steps to reproduce provided in #29823 (comment).

Confirmed I wasn't prompted to save the file with the file picker; it just auto-downloaded, in both Normal and Private-window cases

Settings

Screen Shot 2023-05-26 at 6 48 50 PM

Normal Window

example example example
Screen Shot 2023-05-26 at 6 58 54 PM Screen Shot 2023-05-26 at 6 58 59 PM Screen Shot 2023-05-26 at 6 59 06 PM

Private Window

example example example
Screen Shot 2023-05-26 at 6 59 39 PM Screen Shot 2023-05-26 at 6 59 47 PM Screen Shot 2023-05-26 at 6 59 51 PM

@stephendonner
Copy link

Spun off #30626 while testing the above 👍

@xxjoe2
Copy link

xxjoe2 commented Jun 12, 2023

still showing download prompt for me on both windws and linux in private mode, no problem with chrome (ungoogled) nor vivaldi

https://github.com/brave/brave-browser/releases/download/v1.54.52/brave-v1.54.52-win32-x64.zip

Capture1
Capture2
Capture3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes ask for download location setting in Private windows. brave/brave-core
4 participants
@stephendonner @mkarolin @brave-builds @xxjoe2