Skip to content

Commit

Permalink
Re-enable WindowClosingConfirmBrowserTest.TestWithDownload test on Ma…
Browse files Browse the repository at this point in the history
…cOS.
  • Loading branch information
mkarolin committed Apr 28, 2023
1 parent 06c42a1 commit 7514977
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions browser/ui/window_closing_confirm_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -265,15 +265,7 @@ IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
ui_test_utils::WaitForBrowserToClose(brave_browser);
}

// Temporarily disable the test on MacOS until
// https://github.com/brave/brave-browser/issues/29823 is fixed.
#if BUILDFLAG(IS_MAC)
#define MAYBE_TestWithDownload DISABLED_TestWithDownload
#else
#define MAYBE_TestWithDownload TestWithDownload
#endif
IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
MAYBE_TestWithDownload) {
IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, TestWithDownload) {
// On macOS, download in-progress warning is not shown for normal profile window
// closing as it can still continue after window is closed.
// However, private profile window works like normal window of other platforms.
Expand Down

0 comments on commit 7514977

Please sign in to comment.