Uphold 25 BAT minimum modal triggering in bitFlyer flow

[emerick]

@Miyayes encountered an issue where he was testing the bitFlyer flow, but he received an error modal about the Uphold 25 BAT minimum. After some investigation, @zenparsing noticed that if the claim endpoint returns a 404 it's converted into NOT_FOUND and can accidentally trigger the modal. This may not be the issue we're seeing, but it is one way that it could happen so best to fix it.

Steps to Reproduce

1. Generate a wallet ID while connected to production
2. Relaunch the browser in staging mode
3. Go through the verify wallet process (which will correctly go against staging servers)
4. Note that everything works until you're redirected back to to the brave://rewards page, where it will fail and show the Uphold error

Presumably, underlying issue is that the wallet ID is not found, since that wallet ID is in the production db and not in the staging db.

[Miyayes]

Reopening to add some STR.

Steps to Reproduce

1. Generate a wallet ID while connected to production
2. Relaunch the browser in staging mode
3. Go through the verify wallet process (which will correctly go against staging servers)
4. Note that everything works until you're redirected back to to the brave://rewards page, where it will fail and show the Uphold error

Presumably, underlying issue is that the wallet ID is not found, since that wallet ID is in the production db and not in the staging db.

[emerick]

@Miyayes Our original fix for this addresses the new STR as well, so I'll close this out. One thing to note, however, is that an error like this drops us into a modal that only offers a "Try again" option. In a scenario like this, trying again isn't going to fix anything. We should have another option in there to dismiss the modal.

[Miyayes]

Thanks @emerick. I also just filed: #15338 regarding the close button! I remember being sent in loops because there was no close button ;)

[stephendonner]

Verified PASSED using the steps and testplan from #15264 (comment)

Brave	1.25.46 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 11.3 (Build 20E232)

Steps:

1. set my macOS region to Japan, language to Japanese, restarted the OS
2. launched Brave and enabled Rewards via the NTP page
3. relaunched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
4. via brave://flags, set Enable bitFlyer for Brave Rewards to Enabled, and restarted using the commandline, above
5. clicked on the Japanese-text equivalent of Verify Wallet
6. confirmed I was taken to the bitFlyer staging environment
7. clicked on the blue/purple button (not pictured, sorry!)
8. received an error message
9. confirmed that there was a (x) widget at the top right, and that clicking on it closed the error-message popup, and returned me to brave://rewards

I confirmed with @Miyayes that the error message triggered here is from us, not the Uphold minimum-25 BAT message (which I'm familiar with), and that that's what's needed to verify the issue here is fixed 👍

example	example	example	example	example

---

Verification passed on

Brave	1.25.64 Chromium: 90.0.4430.212 (Official Build) beta （64 ビット）
変更履歴	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Windows 10 OS Version 1809 (Build 17763.1637)

• Verified the STR from Uphold 25 BAT minimum modal triggering in bitFlyer flow #15264 (comment)
  

---

Verification passed on

Brave	1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	Ubuntu 18.04 LTS

• Verified the STR from Uphold 25 BAT minimum modal triggering in bitFlyer flow #15264 (comment)