Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return LEDGER_ERROR when claim endpoint returns 404 #8525

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 13, 2021

Resolves brave/brave-browser#15264

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested a review from zenparsing April 13, 2021 18:22
@emerick emerick self-assigned this Apr 13, 2021
@emerick
Copy link
Contributor Author

emerick commented Apr 14, 2021

All CI passed except Mac; restarting Mac.

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 14, 2021
@emerick emerick force-pushed the rewards-bitflyer-claim-wrong-error branch from 6d6c9ad to 7b63bbb Compare April 14, 2021 01:02
@emerick emerick force-pushed the rewards-bitflyer-claim-wrong-error branch from 7b63bbb to e319a62 Compare April 14, 2021 13:13
@emerick
Copy link
Contributor Author

emerick commented Apr 14, 2021

Mac passed CI; ready to merge.

@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 14, 2021
@emerick emerick merged commit 07a48c4 into master Apr 14, 2021
@emerick emerick deleted the rewards-bitflyer-claim-wrong-error branch April 14, 2021 15:59
@emerick emerick added this to the 1.25.x - Nightly milestone Apr 14, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uphold 25 BAT minimum modal triggering in bitFlyer flow
2 participants