Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close button on error modal for Verify Wallet #8863

Merged
merged 1 commit into from
May 19, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 19, 2021

Resolves brave/brave-browser#15963

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Follow STR in brave/brave-browser#15264 (comment)

@emerick emerick requested a review from a team as a code owner May 19, 2021 14:56
@emerick emerick self-assigned this May 19, 2021
@emerick emerick requested review from jumde and zenparsing May 19, 2021 14:56
@emerick
Copy link
Contributor Author

emerick commented May 19, 2021

CI passed on Windows and Android. CI passed with expected/unrelated browser test failures on Mac and Linux. Restarting for iOS.

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 19, 2021
@emerick emerick force-pushed the rewards-fix-error-modal-close-button branch from 0972cda to 4c65690 Compare May 19, 2021 18:28
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 19, 2021
@emerick
Copy link
Contributor Author

emerick commented May 19, 2021

CI passed on iOS; ready to merge.

@emerick emerick merged commit c4043ed into master May 19, 2021
@emerick emerick deleted the rewards-fix-error-modal-close-button branch May 19, 2021 20:31
@emerick emerick added this to the 1.27.x - Nightly milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up of #15338- Close button doesn't dismiss the wallet verification error modal
2 participants