Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display close button for Rewards error modal #8635

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Display close button for Rewards error modal #8635

merged 1 commit into from
Apr 24, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 23, 2021 •
edited
Loading

Resolves brave/brave-browser#15338

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested a review from zenparsing April 23, 2021 20:44
@emerick emerick self-assigned this Apr 23, 2021
zenparsing
zenparsing reviewed Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - can you attach a screenshot of what the close button looks like on this modal?

@emerick
Copy link
Contributor Author

emerick commented Apr 23, 2021

Yes, looks like this now:

Untitled

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 24, 2021
@emerick
Copy link
Contributor Author

emerick commented Apr 24, 2021

CI passed all platforms except Mac; restarting for Mac.

@emerick emerick force-pushed the rewards-error-modal-close-button branch from e7ee3ec to 45a8bda Compare April 24, 2021 01:51
@emerick
Copy link
Contributor Author

emerick commented Apr 24, 2021

Mac CI passed; ready to merge.

@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 24, 2021
@emerick emerick merged commit 9dc6ca2 into master Apr 24, 2021
@emerick emerick deleted the rewards-error-modal-close-button branch April 24, 2021 09:56
@emerick emerick added this to the 1.25.x - Nightly milestone Apr 24, 2021
kylehickinson pushed a commit that referenced this pull request Jan 12, 2024
@Brandon-T
Fix #8635: URLBar updates and CertValidation (#8634)
b4a9c54 
Update URL bar on cancellation instead of URL change because URL change can update the certificate state.
Remove didCommit serverTrust validation as it works fine with URLBar Revamp.
Make the cert validation function async-await
Remove select as it crashes in debug builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenparsing zenparsing zenparsing approved these changes

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging this pull request may close these issues.

Add "Close" button in Brave Rewards wallet verification error modal
2 participants
@emerick @zenparsing