Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting to disable UGP notifications #1162

Closed
LaurenWags opened this issue Sep 17, 2018 · 2 comments
Closed

setting to disable UGP notifications #1162

LaurenWags opened this issue Sep 17, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 17, 2018

Description

Browser-Laptop advanced preferences has a setting to disable token (UGP) notifications, Brave Rewards should have this as well.

Steps to Reproduce

  1. Navigate to Settings
  2. Look for a way to disable token (UGP) notifications.

Actual result:

No way to disable token (UGP) notifications.

Expected result:

Should be a way to disable token (UGP) notifications.

Reproduces how often:

easily

Brave version (chrome://version info)

all

Reproducible on current release:

yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

On browser-laptop (muon) this is located on the Advanced Settings page (about:preferences#advanced).

@bsclifton bsclifton added the feature/global-settings Settings at browser level independent of shields settings label Sep 17, 2018
@bsclifton bsclifton added this to the 1.0 milestone Sep 17, 2018
@NejcZdovc
Copy link
Contributor

@davidtemkin
Copy link

Not a bug. UGP notifications in Brave Rewards only occur once a user has opted into Brave Rewards.

@NejcZdovc NejcZdovc modified the milestones: 1.0 (0.56.x), Dupe / Invalid / Not actionable Sep 27, 2018
@kjozwiak kjozwiak removed browser-laptop-parity feature/global-settings Settings at browser level independent of shields settings feature/rewards labels Oct 22, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants