Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on Peer ID or PeerID (or...PeerId) #16746

Closed
stephendonner opened this issue Jul 1, 2021 · 1 comment · Fixed by brave/brave-core#9316
Closed

Standardize on Peer ID or PeerID (or...PeerId) #16746

stephendonner opened this issue Jul 1, 2021 · 1 comment · Fixed by brave/brave-core#9316

Comments

@stephendonner
Copy link

Description

(Yes, sorry, this is a tad pedantic.)

We've got IPFS peer IDs written as Peer ID and PeerID - let's choose one, for consistency's sake.

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://ipfs
  4. look at the copy for instances of Peer ID and PeerID

Actual result:

Screen Shot 2021-07-01 at 3 24 36 PM

Expected result:

Should be consistently either Peer ID or PeerID (although https://github.com/libp2p/js-peer-id/tree/e19da79f08f8dc6924a72a688ce563c7fd7b1989#description has it as PeerId in places, heh).

@lidel - which is it, pretty please? 🙇

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.46 Chromium: 92.0.4515.70 (Official Build) nightly (x86_64)
Revision 2df01a82398e62190b2aae01aaad7ca3d47aba01-refs/branch-heads/4515@{#923}
OS macOS Version 11.4 (Build 20F71)
@stephendonner stephendonner added needs-text-change This change requires some careful wording. feature/web3/ipfs OS/Desktop labels Jul 1, 2021
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 2, 2021
@stephendonner stephendonner changed the title Standardized on Peer ID or PeerID (or...PeerId) Standardize on Peer ID or PeerID (or...PeerId) Jul 3, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan on build

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)
  1. new profile
  2. launch Brave
  3. load brave://ipfs
  4. look at the copy for instances of Peer ID and PeerID

Confirmed both instances now read Peer ID

Screen Shot 2021-07-06 at 1 26 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants