Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS flyout share file/folder menu items missing IPNS key, at first #16801

Closed
stephendonner opened this issue Jul 7, 2021 · 4 comments
Closed

Comments

@stephendonner
Copy link

Description

IPFS flyout share file/folder menu items missing IPNS key, at first

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://ipfs
  4. click on Install and start
  5. load brave://settings/ipfs
  6. choose Local node from Method to resolve IPFS resources
  7. click on the "hamburger" menu -> IPFS -> flyout

Actual result:

Until you visit brave://settings/ipfs/keys, it's missing the IPNS key

Screen Shot 2021-07-06 at 5 13 31 PM

Expected result:

Should show the self IPNS key

Screen Shot 2021-07-06 at 5 13 44 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)
@spylogsster
Copy link

we deliberately removed them from this menu
cc @lidel

@stephendonner
Copy link
Author

we deliberately removed them from this menu
cc @lidel

They're not removed; they still show up, as expected, eventually. Did you try the steps verbatim? Do you mean they are supposed to be removed as per those steps, or in general?

@spylogsster spylogsster reopened this Jul 7, 2021
@spylogsster
Copy link

I found that thread brave/brave-core#8706 (comment), you are right, we should show this. sorry @stephendonner

@spylogsster spylogsster self-assigned this Jul 7, 2021
@spylogsster
Copy link

this issue was fixed in #16743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants