Updated Tip settings are not retained after the upgrade

[GeetaSarvadnya]

Description

Updated Tip settings are not retained after the upgrade

Steps to Reproduce

1. Clean profile 1.26.x nightly build
2. Enable rewards
3. Navigate to the Tips panel and uncheck the checkbox for Reddit and Twitter
4. Upgrade profile to 1.28.x nightly build
5. Updated Tip settings are not retained after the upgrade

Actual result:

Updated Tip settings are not retained after the upgrade

Before Upgrade

After Upgrade

Expected result:

Updated Tip settings should retain after upgrade

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (64-bit)
Revision	dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS	Windows 10 OS Version 2004 (Build 19041.1052)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Not sure
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @emerick @rebron

[Miyayes]

Just noting: I view this is as a very bad problem, and I would assign a high priority to it.

[zenparsing]

@GeetaSarvadnya After the upgrade in this scenario, do the tip icons show on the sites that were previously de-selected? (e.g. Twitter, in this case).

[zenparsing]

It appears that the inline tip settings UI is dependent on localStorage to maintain the current UI state, and does not currently request updated pref values from the browser.

[GeetaSarvadnya]

@zenparsing @Miyayes My observation is as below:

1. Install 1.26.x nightly build
2. Enable rewards and uncheck Twitter and Reddit checkboxes in the Tips panel
3. Open https://twitter.com/bravelaurenwags and observed inline tip button is available (known issue Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings  #12870 (comment))
4. Restart the browser
5. Ensured inline tip is NOT available in https://twitter.com/bravelaurenwags (as expected)
6. Upgrade profile to 1.28.x nightly build
7. Encountered the issue Updated Tip settings are not retained after the upgrade #16871 (comment) (Twitter and Reddit checkboxes are selected)
8. Open https://twitter.com/bravelaurenwags and ensured Inline Tip is NOT available as expected (although the Twitter option selected in step 7)

Looks like it's UI issue it's not impacting the inline tip button in Twitter/Reddit.

[GeetaSarvadnya]

Verification passed on

Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)

• Verified the STR from the description and ensured updated Tip settings are retained after the upgrade