Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localStorage display issues on Rewards settings page (uplift to 1.27.x) #9419

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fix localStorage display issues on Rewards settings page (uplift to 1.27.x) #9419

merged 1 commit into from
Jul 14, 2021

Conversation

zenparsing
Copy link
Collaborator

Uplift of #9385
Resolves brave/brave-browser#16873
Resolves brave/brave-browser#16871

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing requested a review from a team as a code owner July 13, 2021 20:26
@zenparsing zenparsing requested review from emerick and szilardszaloki and removed request for a team July 13, 2021 20:26
@LaurenWags LaurenWags requested a review from a team July 14, 2021 12:49
@zenparsing
Copy link
Collaborator Author

CI results:

  • SonarCloud Code Analysis is indicating 2 duplicated lines on new code; this is expected given how the rewards page is currently structured.

LaurenWags
LaurenWags approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.27.x is approved after deliberating with @brave/uplift-approvers 👍🏻

@LaurenWags LaurenWags merged commit 8413a5b into 1.27.x Jul 14, 2021
@LaurenWags LaurenWags deleted the ksmith-rewards-page-ui-bugs-1.27.x branch July 14, 2021 14:17
@LaurenWags LaurenWags added this to the 1.27.x - Beta milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

@emerick emerick Awaiting requested review from emerick

@szilardszaloki szilardszaloki Awaiting requested review from szilardszaloki

Assignees

@zenparsing zenparsing

Labels
None yet
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @LaurenWags