Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Together text and image assets should read Brave Talk, in new-tab page's cards #16798

Closed
stephendonner opened this issue Jul 6, 2021 · 5 comments · Fixed by brave/brave-core#9552

Comments

@stephendonner
Copy link

Description

Brave Together text and image assets should read Brave Talk, in new-tab page's cards

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. open a new-tab page
  4. click on Customize on the bottom right
  5. click on Cards
  6. look at Brave Together's text and image
  7. click + Add
  8. now, look at the added widget
  9. click on the ... and look at the resulting menu item

Actual result:

Cards pane Brave Together widget Hide Brave Together menu item
Screen Shot 2021-07-06 at 4 26 11 PM Screen Shot 2021-07-06 at 4 32 14 PM Screen Shot 2021-07-06 at 4 32 09 PM

Expected result:

Should read Brave Talk in each of the above 3 UI elements.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

@karenkliu can you/the team help provide new assets? Thanks!

/cc @simonhong @petemill (I'll leave renaming to the pros, since I don't know what else I could break with simple text changes!)

@karenkliu
Copy link

Here's the link to the updated asset in Figma: https://www.figma.com/file/0pOzvvueMoeaCxKaVoU59Z/Widget-discovery?node-id=2506%3A23053 :)

bsclifton added a commit to brave/brave-core that referenced this issue Jul 26, 2021
Updates widget itself, settings screen (under customize), and a few
comments in the code

Fixes brave/brave-browser#16798
@bsclifton bsclifton self-assigned this Jul 27, 2021
@bsclifton bsclifton added this to the 1.29.x - Nightly milestone Jul 28, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with

Brave 1.29.36 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)

Steps:

  1. new profile
  2. launch Brave
  3. open a new-tab page
  4. click on Customize on the bottom right
  5. click on Cards
  6. look at Brave Talk's text and image
  7. click ``+ Add`
  8. now, look at the added widget
  9. click on the ... and look at the resulting menu item
cards pane new-tab page widget w/Hide menu item
Screen Shot 2021-07-28 at 3 33 52 PM Screen Shot 2021-07-28 at 3 37 37 PM

@stephendonner
Copy link
Author

@bsclifton mind getting an uplift going for 1.28.x? /cc @mattmcalister

@bsclifton
Copy link
Member

@stephendonner done - brave/brave-core#9608

@LaurenWags
Copy link
Member

Changing label to release-notes/exclude since Brave Talk is not enabled in this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment