Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add mouse grab example #4114

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Add mouse grab example #4114

wants to merge 4 commits into from

Conversation

emersonmx
Copy link
Contributor

@emersonmx emersonmx commented Mar 5, 2022 •
edited
Loading

Fixes #4094

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 5, 2022
alice-i-cecile
alice-i-cecile reviewed Mar 5, 2022
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile requested changes Mar 5, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a tiny suggestion to improve the description.

@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Mar 5, 2022
@emersonmx @alice-i-cecile
Update examples/README.md
391b475 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
james7132
james7132 requested changes Mar 8, 2022
View reviewed changes
examples/input/mouse_grab.rs Outdated Show resolved Hide resolved
examples/input/mouse_grab.rs Outdated Show resolved Hide resolved
@emersonmx @james7132
Update examples/input/mouse_grab.rs
4ea9ac4 
Co-authored-by: James Liu <contact@jamessliu.com>
@emersonmx @alice-i-cecile
Update examples/input/mouse_grab.rs
cfe629c 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@alice-i-cecile
Copy link
Member

Awesome. Once I have a second approval I'm ready to merge this :)

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2022
@emersonmx
Add mouse grab example (#4114)
6ce8e50 
Fixes #4094
@bors
Copy link
Contributor

bors bot commented Mar 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add mouse grab example [Merged by Bors] - Add mouse grab example Mar 8, 2022
@bors bors bot closed this Mar 8, 2022
@emersonmx emersonmx deleted the add-mouse-grab-example branch March 8, 2022 19:28
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@emersonmx @aevyrie
Add mouse grab example (bevyengine#4114)
02095c7 
Fixes bevyengine#4094
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@emersonmx @ItsDoot
Add mouse grab example (bevyengine#4114)
fdd261e 
Fixes bevyengine#4094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example for grabbing the mouse
3 participants
@emersonmx @alice-i-cecile @james7132