don't crash without features bevy_pbr, ktx2, zstd
#14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jun 25, 2024
alice-i-cecile
added
C-Bug
jgayfer
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Tested against bevy_light_2d and confirmed that it fixes the need to include ktx2, zstd, and bevy_pbr.
Code wise it looks reasonable, though I'm not familiar with what is being put behind the new feature flag.
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
added a commit
that referenced
this pull request
Jun 26, 2024
# Objective - Fixes #13728 ## Solution - add a new feature `smaa_luts`. if enables, it also enables `ktx2` and `zstd`. if not, it doesn't load the files but use placeholders instead - adds all the resources needed in the same places that system that uses them are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
0.14.0-rc.2, minimal app withbevy_core_pipelinecrashes withoutktx2,zstd, andbevy_pbr#13728Solution
smaa_luts. if enables, it also enablesktx2andzstd. if not, it doesn't load the files but use placeholders instead