Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when bevy_pbr feature is not included #13571

Closed
jgayfer opened this issue May 29, 2024 · 3 comments
Closed

Panic when bevy_pbr feature is not included #13571

jgayfer opened this issue May 29, 2024 · 3 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@jgayfer
Copy link
Contributor

jgayfer commented May 29, 2024

Overview

When the bevy_pbr feature is omitted (as in the below example), the following error occurs:

thread 'main' panicked at /Users/jgayfer/.cargo/git/checkouts/bevy-f7ffde730c324c74/9d74e16/crates/bevy_ecs/src/system/system_param.rs:619:17:
Resource requested by bevy_core_pipeline::core_3d::extract_core_3d_camera_phases does not exist: bevy_render::render_phase::ViewBinnedRenderPhases<bevy_core_pipeline::core_3d::Opaque3d>

The error does not occur if bevy_pbr is included.

Possibly related to #13175, but I've opened a separate issue as the errors are not the same.

Bevy version

4065098586519a1764a462c02a63f299114c35c9 (main)

Relevant system information

AdapterInfo { name: "Apple M1 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

Minimal example

# Cargo.toml
[package]
name = "pbr_test"
version = "0.1.0"
edition = "2021"

[dependencies]
bevy = { git = "https://github.com/bevyengine/bevy", branch = "main", default-features = false, features = [
    "bevy_winit"
] }
use bevy::prelude::*;

fn main() {
    App::new().add_plugins(DefaultPlugins).run();
}
@jgayfer jgayfer added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 29, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels May 30, 2024
@knutsoned
Copy link

Can confirm this issue also happened for me on a project, and adding bevy_pbr fixed it

@aevyrie
Copy link
Member

aevyrie commented Jun 12, 2024

Ran into this when updating bevy_framepace. Confirmed issue and fix.

@jgayfer
Copy link
Contributor Author

jgayfer commented Jun 26, 2024

Closed by #14020

@jgayfer jgayfer closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

No branches or pull requests

4 participants