Clean up type registrations #12314
Merged
Clean up type registrations #12314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
C-Code-Quality
pablo-lua
suggested changes
Mar 5, 2024
crates/bevy_pbr/src/lib.rs
Outdated
| .register_type::<CascadeShadowConfig>() | ||
| .register_type::<Cascades>() | ||
| .register_type::<CascadesVisibleEntities>() | ||
| .register_type::<ClusterConfig>() | ||
| .register_type::<ClusterFarZMode>() |
There was a problem hiding this comment.
Can't we remove ClusterFarZMode? After all, ClusterZConfig has this types in fields.
ClusterConfig has some types too.
There was a problem hiding this comment.
Actually, this file has some other kinds that can be removed as well.
There was a problem hiding this comment.
Should be more cleaned up now.
pablo-lua
approved these changes
Mar 6, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Mar 6, 2024
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective Fix bevyengine#12304. Remove unnecessary type registrations thanks to bevyengine#4154. ## Solution Conservatively remove type registrations. Keeping the top level components, resources, and events, but dropping everything else that is a type of a member of those types.
BD103
added
the
C-Breaking-Change
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #12304. Remove unnecessary type registrations thanks to #4154.
Solution
Conservatively remove type registrations. Keeping the top level components, resources, and events, but dropping everything else that is a type of a member of those types.