Fix scene example

[tim-blackbird]

Since #9907 the generation starts at 1 instead of 0 so Entity::to_bits now returns 4294967296 (ie. u32::MAX + 1) as the lowest number instead of 0.

Without this change scene loading fails with this error message:
ERROR bevy_asset::server: Failed to load asset 'scenes/load_scene_example.scn.ron' with asset loader 'bevy_scene::scene_loader::SceneLoader': Could not parse RON: 8:6: Invalid generation bits

[doonv]

Why use a random number and not 1?

[tim-blackbird]

It's not random :')
I've updated the first line in the PR description to be more clear.

[doonv]

Ah, maybe add a comment so its more clear why that number is being used?

[tim-blackbird]

Honestly the entire example is flawed and bound to be reworked when proper scene infrastructure rolls around, hopefully soon. Not sure if it's worth documenting at this point, you honestly just should not do serialization the way this example does, but I don't think deleting the example is an option

[Vrixyz]

If that fixes an example I'm all for it :D

That said ; isn't the root cause using to_bits()¹ ? or something else ? in my opinion this complicates the ron format, which I'd like to make sense of easily, seeing these kind of "magic" numbers don't facilitate understanding.

Footnotes

1. docs of to_bits states it shouldn't be used in serialization ? https://github.com/bevyengine/bevy/blob/main/crates/bevy_ecs/src/entity/mod.rs#L258-L259 ↩

[tim-blackbird]

Yep. This entire way of serializing entities is terribly flawed, but the example exists as-is so it's better if it actually works.
Certified jank :')