Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some frame checks #206

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

ggoretkin-bdai
Copy link
Collaborator

@ggoretkin-bdai ggoretkin-bdai commented Dec 5, 2023

Functionally equivalent (slightly different error message).

@ggoretkin-bdai
Copy link
Collaborator Author

@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Use_self.frame_prefix_instead_of_frame_prefix_ branch from 5e602e5 to 83af677 Compare December 5, 2023 19:55
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Clean_up_some_frame_checks branch from c94f043 to 0a0ed75 Compare December 5, 2023 19:55
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Use_self.frame_prefix_instead_of_frame_prefix_ branch from 83af677 to 95c47ce Compare December 5, 2023 19:57
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Clean_up_some_frame_checks branch from 0a0ed75 to 7602444 Compare December 5, 2023 19:57
@ggoretkin-bdai ggoretkin-bdai marked this pull request as ready for review December 5, 2023 21:59
mhidalgo-bdai
mhidalgo-bdai previously approved these changes Dec 6, 2023
Copy link
Collaborator

@mhidalgo-bdai mhidalgo-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amessing-bdai
amessing-bdai previously approved these changes Dec 7, 2023
ksharma-bdai
ksharma-bdai previously approved these changes Dec 7, 2023
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Use_self.frame_prefix_instead_of_frame_prefix_ branch from 95c47ce to d730060 Compare December 7, 2023 18:24
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Clean_up_some_frame_checks branch from 7602444 to 9aca92a Compare December 7, 2023 18:24
@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Use_self.frame_prefix_instead_of_frame_prefix_ branch from d730060 to 91f3a61 Compare December 13, 2023 15:16
Base automatically changed from 12-05-Use_self.frame_prefix_instead_of_frame_prefix_ to main December 18, 2023 16:07
@bhung-bdai bhung-bdai dismissed stale reviews from ksharma-bdai, amessing-bdai, and mhidalgo-bdai December 18, 2023 16:07

The base branch was changed.

@ggoretkin-bdai
Copy link
Collaborator Author

ggoretkin-bdai commented Dec 18, 2023

Merge activity

  • Dec 18, 11:07 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Dec 18, 1:40 PM: @@ggoretkin-bdai merged this pull request with Graphite.

@ggoretkin-bdai ggoretkin-bdai force-pushed the 12-05-Clean_up_some_frame_checks branch from 9aca92a to f75ae48 Compare December 18, 2023 16:07
Copy link
Collaborator Author

@ggoretkin-bdai ggoretkin-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that the reviews got dismissed again.... @amessing-bdai @ksharma-bdai @mhidalgo-bdai

@ggoretkin-bdai ggoretkin-bdai merged commit dc50304 into main Dec 18, 2023
4 checks passed
@ggoretkin-bdai ggoretkin-bdai deleted the 12-05-Clean_up_some_frame_checks branch December 18, 2023 18:40
marlow-fawn pushed a commit to marlow-fawn/spot_ros2 that referenced this pull request Aug 19, 2024
Functionally equivalent (slightly different error message).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants