Use self.frame_prefix instead of frame_prefix
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ggoretkin-bdai
force-pushed
the
12-05-Use_self.frame_prefix_instead_of_frame_prefix_
branch
from
5e602e5 to
83af677
Compare
ggoretkin-bdai
force-pushed
the
11-21-_N/A_Add_a_mock_launch_argument
branch
from
9725e97 to
166eb4e
Compare
ggoretkin-bdai
force-pushed
the
12-05-Use_self.frame_prefix_instead_of_frame_prefix_
branch
from
83af677 to
95c47ce
Compare
ggoretkin-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
ksharma-bdai
as code owners
amessing-bdai
previously approved these changes
Dec 7, 2023
ksharma-bdai
previously approved these changes
Dec 7, 2023
bhung-bdai
previously approved these changes
Dec 7, 2023
ggoretkin-bdai
force-pushed
the
12-05-Use_self.frame_prefix_instead_of_frame_prefix_
branch
from
95c47ce to
d730060
Compare
Base automatically changed from
11-21-_N/A_Add_a_mock_launch_argument
to
main
December 8, 2023 18:43
bhung-bdai
dismissed stale reviews from mhidalgo-bdai, ksharma-bdai, amessing-bdai, and themself
The base branch was changed.
|
I am not sure why the review approvals are not showing anymore... can @ksharma-bdai and @bhung-bdai re-approve, please? |
bhung-bdai
approved these changes
Dec 13, 2023
ggoretkin-bdai
force-pushed
the
12-05-Use_self.frame_prefix_instead_of_frame_prefix_
branch
from
d730060 to
91f3a61
Compare
bhung-bdai
deleted the
12-05-Use_self.frame_prefix_instead_of_frame_prefix_
branch
marlow-fawn
pushed a commit
to marlow-fawn/spot_ros2
that referenced
this pull request
Aug 19, 2024
All uses of "frame_prefix" are either via `self.frame_prefix` or `self.spot_wrapper.frame_prefix` now, reducing potential divergence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of "frame_prefix" are either via
self.frame_prefixorself.spot_wrapper.frame_prefixnow, reducing potential divergence.