feat: add parameter argument for lanelet2_map_loader #954

h-ohta · 2022-05-24T06:17:53Z

Signed-off-by: h-ohta hiroki.ota@tier4.jp

Description

The continuation of refactor: tier4_map_launch #953
add lanelet2_map_loader_param_path argument
add centerline_resolution and lanelet2_map_projector_type in lanelet2_map_loader.param.yam

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

yukkysaito

LGTM

codecov · 2022-05-24T06:26:33Z

Codecov Report

Merging #954 (60b6672) into main (f2577c6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #954   +/-   ##
=====================================
  Coverage   9.53%   9.53%           
=====================================
  Files        939     939           
  Lines      58407   58407           
  Branches   10638   10638           
=====================================
  Hits        5570    5570           
  Misses     48118   48118           
  Partials    4719    4719

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <ø> (?)`
total	`9.53% <ø> (ø)`		Carriedforward from 7e6efe6

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c484d8f...60b6672. Read the comment docs.

…ion#954) * feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit a2dc52036f5950188b5b4caedb2edcd36d3e5860. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: raw_vehicle_cmd_converter (autowarefoundation#9) * remove dependency to unused std_msgs package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rm COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter.launch to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * remove include_directories form CMakeLists.txt Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix order of includes Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add missing comments Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: raw_vehicle_cmd_converter (autowarefoundation#161) * Add linters * Process linter corrections * apply env_var to use_sim_time (autowarefoundation#222) * Ros2 v0.8.0 raw vehicle cmd converter (autowarefoundation#268) * restore raw_vehicle_cmd_converter files for 0.8.0 update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typos in vehicle modules (autowarefoundation#954) * add get func (autowarefoundation#1088) * Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update" This reverts commit f243f26e20490757a332566aa92196553a682aa6. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * update target branch for ci (autowarefoundation#309) * update target branch for ci Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [as]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [latlon_muxer]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [raw_vehicle_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [remote_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [turn_signal_decider]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add plot_accel_brake_map.py (autowarefoundation#1249) (autowarefoundation#1296) * add plot_accel_brake_map.py (autowarefoundation#1249) * add plot_accel_brake_map.py * call plotter from rosrun * add permission Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * delete debug message * Add license Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * apply format * fix code Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * enable to designate directory of maps (autowarefoundation#1301) (autowarefoundation#1480) * enable to designate directory of maps * add error handling * use argparser Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688) * Feature/vehicle interface improvements (autowarefoundation#1361) * add vehicle msg * add pacmod interface * add eps controller * use each control commands instead of vehicle command * fixed details * fixed speell check * const * fixed brake status * publish cmd when recieving ctrl cmd * fix shift cmd ptr * remove unused function and set proper license * fix names * fix typo for pacmod * remove unnecessary waiting * use flags, limit, multiarray * remove accel brake dependency * fix retrun value * replace eps to steer * cosmetic change for namespace * fix segfo and retval * Use Enum instead of int * remove unused var * add const * rename to calcFFMap * prev time steer calc * add sample csv * add new line Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build failure for remote cmd converter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717) * Fix subscriber topic type Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix rclcpp::Time initialization Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * default debug value false in raw vehicle cmd converter (autowarefoundation#1755) * default debug value false in raw vehicle cmd converter * spell check * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [raw vehicle cmd converter] apply autoware auto msgs (autowarefoundation#519) * remove ignore * replace to autoware auto control message * use localization odometry * apply steering report * appluy clang format * cosmetic change * fix spell check * update to readme * update launch * minor fix * precommit fix * update README.md Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * using AckermannControlCommand * fix format Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * move cmd converters to control pkg (autowarefoundation#642) * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit 19a10f9419aa25ef7a37e51c5df8f65b75cf8887. * fix topic * Auto/readme cmd converter (autowarefoundation#692) * fix format * add readme external cmd converter * fix lint * fiix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix format Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * better expression Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix door cmd topic (autowarefoundation#711) * fix door cmd topic * fix topic Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

…dation#5325) (autowarefoundation#954) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

feat: add parameter argument for lanelet2_map_loader

7e6efe6

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

h-ohta requested review from yukkysaito and kenji-miyake May 24, 2022 06:17

feat: add comment

60b6672

kenji-miyake approved these changes May 24, 2022

View reviewed changes

yukkysaito approved these changes May 24, 2022

View reviewed changes

h-ohta enabled auto-merge (squash) May 24, 2022 06:23

h-ohta merged commit 0fdafe6 into autowarefoundation:main May 24, 2022

tier4-autoware-public-bot bot mentioned this pull request May 25, 2022

chore: sync upstream tier4/autoware.universe#49

Merged

h-ohta deleted the feat/parameter_map_launch branch August 18, 2022 10:07

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022

feat: add parameter argument for lanelet2_map_loader (tier4#954)

7dd2ff2

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

feat: add parameter argument for lanelet2_map_loader (tier4#954)

d52bbae

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

feat: add parameter argument for lanelet2_map_loader (tier4#954)

4ea8d10

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022

feat: add parameter argument for lanelet2_map_loader (tier4#954)

7a80eae

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

h-ohta referenced this pull request in tier4/autoware.universe Jan 26, 2023

feat: add parameter argument for lanelet2_map_loader (#954)

d2a0d38

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

h-ohta referenced this pull request in tier4/autoware.universe Jan 26, 2023

feat: add parameter argument for lanelet2_map_loader (#954)

d71050c

* feat: add parameter argument for lanelet2_map_loader Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * feat: add comment

h-ohta mentioned this pull request Jan 27, 2023

fix(lanelet2_map_loader): delete unused parameters #2761

Merged

4 tasks

YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Oct 19, 2023

fix(drivable_area_expansion): correct bound limit check (autowarefoun…

7ee4a91

…dation#5325) (autowarefoundation#954) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add parameter argument for lanelet2_map_loader #954

feat: add parameter argument for lanelet2_map_loader #954

h-ohta commented May 24, 2022 •

edited by kenji-miyake

Loading

yukkysaito left a comment

codecov bot commented May 24, 2022 •

edited

Loading

feat: add parameter argument for lanelet2_map_loader #954

feat: add parameter argument for lanelet2_map_loader #954

Conversation

h-ohta commented May 24, 2022 • edited by kenji-miyake Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

yukkysaito left a comment

Choose a reason for hiding this comment

codecov bot commented May 24, 2022 • edited Loading

Codecov Report

h-ohta commented May 24, 2022 •

edited by kenji-miyake

Loading

codecov bot commented May 24, 2022 •

edited

Loading