Support rolling(humble) #268

wep21 · 2022-01-18T10:31:29Z

Some modifications are necessary to migrate to ros2 rolling(humble).
#247

wep21 · 2022-01-18T10:35:24Z

https://docs.ros.org/en/foxy/Releases/Release-Humble-Hawksbill.html

* restore raw_vehicle_cmd_converter files for 0.8.0 update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typos in vehicle modules (autowarefoundation#954) * add get func (autowarefoundation#1088) * Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update" This reverts commit f243f26e20490757a332566aa92196553a682aa6. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit a2dc52036f5950188b5b4caedb2edcd36d3e5860. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: raw_vehicle_cmd_converter (#9) * remove dependency to unused std_msgs package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rm COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter.launch to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * remove include_directories form CMakeLists.txt Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix order of includes Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add missing comments Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: raw_vehicle_cmd_converter (autowarefoundation#161) * Add linters * Process linter corrections * apply env_var to use_sim_time (autowarefoundation#222) * Ros2 v0.8.0 raw vehicle cmd converter (autowarefoundation#268) * restore raw_vehicle_cmd_converter files for 0.8.0 update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typos in vehicle modules (autowarefoundation#954) * add get func (autowarefoundation#1088) * Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update" This reverts commit f243f26e20490757a332566aa92196553a682aa6. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * update target branch for ci (autowarefoundation#309) * update target branch for ci Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [as]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [latlon_muxer]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [raw_vehicle_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [remote_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [turn_signal_decider]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add plot_accel_brake_map.py (autowarefoundation#1249) (autowarefoundation#1296) * add plot_accel_brake_map.py (autowarefoundation#1249) * add plot_accel_brake_map.py * call plotter from rosrun * add permission Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * delete debug message * Add license Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * apply format * fix code Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * enable to designate directory of maps (autowarefoundation#1301) (autowarefoundation#1480) * enable to designate directory of maps * add error handling * use argparser Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688) * Feature/vehicle interface improvements (autowarefoundation#1361) * add vehicle msg * add pacmod interface * add eps controller * use each control commands instead of vehicle command * fixed details * fixed speell check * const * fixed brake status * publish cmd when recieving ctrl cmd * fix shift cmd ptr * remove unused function and set proper license * fix names * fix typo for pacmod * remove unnecessary waiting * use flags, limit, multiarray * remove accel brake dependency * fix retrun value * replace eps to steer * cosmetic change for namespace * fix segfo and retval * Use Enum instead of int * remove unused var * add const * rename to calcFFMap * prev time steer calc * add sample csv * add new line Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build failure for remote cmd converter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717) * Fix subscriber topic type Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix rclcpp::Time initialization Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * default debug value false in raw vehicle cmd converter (autowarefoundation#1755) * default debug value false in raw vehicle cmd converter * spell check * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [raw vehicle cmd converter] apply autoware auto msgs (autowarefoundation#519) * remove ignore * replace to autoware auto control message * use localization odometry * apply steering report * appluy clang format * cosmetic change * fix spell check * update to readme * update launch * minor fix * precommit fix * update README.md Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * using AckermannControlCommand * fix format Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * move cmd converters to control pkg (autowarefoundation#642) * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit 19a10f9419aa25ef7a37e51c5df8f65b75cf8887. * fix topic * Auto/readme cmd converter (autowarefoundation#692) * fix format * add readme external cmd converter * fix lint * fiix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix format Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * better expression Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix door cmd topic (autowarefoundation#711) * fix door cmd topic * fix topic Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

stale · 2022-03-24T13:07:54Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

kenji-miyake · 2022-03-24T22:09:59Z

We have to plan migration steps to Humble.

My (super rough) proposal is:

Support rolling after Ubuntu 22.04 is released. (Around the end of April.)
- If a change is supported by Galactic, merge to the main branch.
- If not, merge to the rolling branch.
Support Humble after ROS 2 Humble is released. (Around the end of May.)
- Ideally, just renaming rolling to humble.
Create the galactic branch and merge humble to main.

@xmfcx @mitsudome-r What do you think about it?

kenji-miyake · 2022-04-18T07:22:04Z

PRs/Issues for Rolling/Humble.
https://github.com/autowarefoundation/autoware.universe/labels/rolling
https://github.com/autowarefoundation/autoware.universe/labels/humble

kenji-miyake · 2022-04-18T07:41:32Z

I'll set up Ubuntu 22.04 next week and work in a branch.

kenji-miyake · 2022-04-21T10:33:41Z

TODO: Remove workarounds after we moved to Humble.
#720

kenji-miyake · 2022-05-05T15:22:38Z

@esteve From your ROS experiences, do you have any suggestions on this?
#268 (comment)

esteve · 2022-05-05T15:53:18Z

@kenji-miyake in my opinion, the plan sounds good. After Humble is released, we won't be supporting Rolling, right?

kenji-miyake · 2022-05-05T15:57:27Z

@esteve No, I believe we won't (at least proactively).
But if someone wants to add the Rolling support by using ROS_DISTRO macros, I think it can be acceptable.
However, it cannot be a mandatory condition for merging PRs because Rolling may collapse frequently.

stale · 2022-07-04T17:19:46Z

This pull request has been automatically marked as stale because it has not had recent activity.

kenji-miyake · 2022-07-04T17:25:49Z

Now the main branch supports both Galactic and Humble.
See autowarefoundation/autoware#2692 for further information.

…rom_private/traffic_light (autowarefoundation#2790) (autowarefoundation#268) * fix(behavior_velocity_planner): clean up expired intersection * clean up expired merge_from_private * clean up expired traffic_light --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 24, 2022

wep21 added the type:new-feature New functionalities or additions, feature requests. label Mar 24, 2022

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Mar 24, 2022

kenji-miyake self-assigned this Apr 21, 2022

kenji-miyake mentioned this issue Jun 26, 2022

Support ROS 2 Rolling on Ubuntu 22.04 autowarefoundation/autoware#2435

Closed

3 tasks

kenji-miyake mentioned this issue May 5, 2022

refactor: simplify Rolling support #854

Merged

4 tasks

kenji-miyake mentioned this issue May 26, 2022

ci: support multi distro CI #967

Merged

4 tasks

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 4, 2022

kenji-miyake closed this as completed Jul 4, 2022

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022

Add CI for develop branch (autowarefoundation#268)

e9531bf

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022

fix: planning simulator launch (autowarefoundation#268)

49c95a8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support rolling(humble) #268

Support rolling(humble) #268

wep21 commented Jan 18, 2022 •

edited

Loading

wep21 commented Jan 18, 2022

stale bot commented Mar 24, 2022

kenji-miyake commented Mar 24, 2022

kenji-miyake commented Apr 18, 2022 •

edited

Loading

kenji-miyake commented Apr 18, 2022

kenji-miyake commented Apr 21, 2022

kenji-miyake commented May 5, 2022

esteve commented May 5, 2022

kenji-miyake commented May 5, 2022

stale bot commented Jul 4, 2022

kenji-miyake commented Jul 4, 2022

Support rolling(humble) #268

Support rolling(humble) #268

Comments

wep21 commented Jan 18, 2022 • edited Loading

wep21 commented Jan 18, 2022

stale bot commented Mar 24, 2022

kenji-miyake commented Mar 24, 2022

kenji-miyake commented Apr 18, 2022 • edited Loading

kenji-miyake commented Apr 18, 2022

kenji-miyake commented Apr 21, 2022

kenji-miyake commented May 5, 2022

esteve commented May 5, 2022

kenji-miyake commented May 5, 2022

stale bot commented Jul 4, 2022

kenji-miyake commented Jul 4, 2022

wep21 commented Jan 18, 2022 •

edited

Loading

kenji-miyake commented Apr 18, 2022 •

edited

Loading