Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_object_fusion_to_detected_object): enable confidence compensation in radar fusion #1755

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 1, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Add confidence compensation in radar fusion.
Along with that, fix bug of confidence hundling and add debug topic for radar fusion package.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
…r fusion

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 marked this pull request as ready for review September 1, 2022 03:47
@scepter914 scepter914 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 1, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1755 (9d7935f) into main (c0f3507) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   10.40%   10.39%   -0.02%     
==========================================
  Files        1218     1218              
  Lines       87550    87654     +104     
  Branches    20511    20511              
==========================================
  Hits         9109     9109              
- Misses      68981    69085     +104     
  Partials     9460     9460              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from c0f3507

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...object/include/radar_fusion_to_detected_object.hpp 0.00% <ø> (ø)
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <0.00%> (ø)
...de/radar_object_fusion_to_detected_object_node.cpp 0.00% <0.00%> (ø)
...dummy_infrastructure/dummy_infrastructure_node.hpp 0.00% <ø> (ø)
..._infrastructure_node/dummy_infrastructure_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 changed the title feat(tier4_perception_launch): enable confidence compensation in radar fusion feat(radar_object_fusion_to_detected_object): enable confidence compensation in radar fusion Sep 1, 2022
scepter914 and others added 4 commits September 5, 2022 12:46
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@yukkysaito
Copy link
Contributor

@scepter914
The title is in radar fusion, but it is enabled for lidar only and camera_lidar as well.
Can you change the PR title?

@yukkysaito yukkysaito requested a review from yukke42 September 5, 2022 13:02
@scepter914
Copy link
Contributor Author

The title is in radar fusion, but it is enabled for lidar only and camera_lidar as well.

Confidence compensation is just the feature of radar fusion and is not relate to LiDAR or Camera-LiDAR fusion.
I changed LiDAR or Camera-LiDAR fusion launcher to enable confidence compensation option of radar fusion, but it doesn't affect LiDAR and Camera-LiDAR fusion.

@yukkysaito yukkysaito self-requested a review September 6, 2022 08:48
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@miursh pls double check

Signed-off-by: scepter914 <scepter914@gmail.com>
…compensation' into feature/radar_fusion_confidence_compensation
@scepter914 scepter914 enabled auto-merge (squash) September 8, 2022 05:12
@scepter914 scepter914 merged commit 364503c into autowarefoundation:main Sep 8, 2022
@scepter914 scepter914 deleted the feature/radar_fusion_confidence_compensation branch September 8, 2022 05:47
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
…nsation in radar fusion (autowarefoundation#1755)

* update parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* feature(radar_fusion_to_detected_object): add debug topic

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(tier4_perception_launch): enable confidence compensation in radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* add compensate probability paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…nsation in radar fusion (tier4#1755)

* update parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* feature(radar_fusion_to_detected_object): add debug topic

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(tier4_perception_launch): enable confidence compensation in radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* add compensate probability paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…nsation in radar fusion (tier4#1755)

* update parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* feature(radar_fusion_to_detected_object): add debug topic

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(tier4_perception_launch): enable confidence compensation in radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* add compensate probability paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…nsation in radar fusion (tier4#1755)

* update parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* feature(radar_fusion_to_detected_object): add debug topic

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(tier4_perception_launch): enable confidence compensation in radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* add compensate probability paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…nsation in radar fusion (tier4#1755)

* update parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* feature(radar_fusion_to_detected_object): add debug topic

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(tier4_perception_launch): enable confidence compensation in radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* add compensate probability paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* update paramter

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameter

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants