Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_bytetrack): fix clang-diagnostic-implicit-const-int-float-conversion #9468

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-implicit-const-int-float-conversion error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_bytetrack/lib/include/byte_tracker.h:86:77: error: implicit conversion from 'long' to 'float' changes value from 9223372036854775807 to 9223372036854775808 [clang-diagnostic-implicit-const-int-float-conversion]
    std::vector<int> & colsol, bool extend_cost = false, float cost_limit = LONG_MAX,
                                                                          ~ ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc November 26, 2024 05:01
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.27%. Comparing base (b3ded07) to head (0c1cdb4).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9468      +/-   ##
==========================================
- Coverage   29.27%   29.27%   -0.01%     
==========================================
  Files        1441     1441              
  Lines      108616   108617       +1     
  Branches    41571    41582      +11     
==========================================
  Hits        31794    31794              
- Misses      73663    73740      +77     
+ Partials     3159     3083      -76     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.27% <ø> (-0.01%) ⬇️ Carriedforward from 19364ff

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@manato @YoshiRi
Please confirm the PR. Thank you very much.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit ce49bfc into autowarefoundation:main Dec 1, 2024
55 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-pe1 branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants