Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_lidar_centerpoint): fix clang-diagnostic-delete-abstract-non-virtual-dtor #9515

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-delete-abstract-non-virtual-dtor error.

/usr/include/c++/11/bits/unique_ptr.h:85:2: error: delete called on 'autoware::lidar_centerpoint::VoxelGeneratorTemplate' that is abstract but has non-virtual destructor [clang-diagnostic-delete-abstract-non-virtual-dtor]
        delete __ptr;
        ^
/usr/include/c++/11/bits/unique_ptr.h:361:4: note: in instantiation of member function 'std::default_delete<autoware::lidar_centerpoint::VoxelGeneratorTemplate>::operator()' requested here
          get_deleter()(std::move(__ptr));
          ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_lidar_centerpoint/lib/centerpoint_trt.cpp:34:17: note: in instantiation of member function 'std::unique_ptr<autoware::lidar_centerpoint::VoxelGeneratorTemplate>::~unique_ptr' requested here
CenterPointTRT::CenterPointTRT(
                ^
/usr/include/c++/11/bits/unique_ptr.h:85:2: error: delete called on non-final 'autoware::lidar_centerpoint::VoxelGenerator' that has virtual functions but non-virtual destructor [clang-diagnostic-delete-non-abstract-non-virtual-dtor]
        delete __ptr;
        ^
/usr/include/c++/11/bits/unique_ptr.h:361:4: note: in instantiation of member function 'std::default_delete<autoware::lidar_centerpoint::VoxelGenerator>::operator()' requested here
          get_deleter()(std::move(__ptr));
          ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_lidar_centerpoint/lib/centerpoint_trt.cpp:39:13: note: in instantiation of member function 'std::unique_ptr<autoware::lidar_centerpoint::VoxelGenerator>::~unique_ptr' requested here
  vg_ptr_ = std::make_unique<VoxelGenerator>(densification_param, config_);
            ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 28, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2024
@kobayu858 kobayu858 requested a review from veqcc November 28, 2024 08:50
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.51%. Comparing base (4e93960) to head (6f2561a).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...e/lidar_centerpoint/preprocess/voxel_generator.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9515      +/-   ##
==========================================
- Coverage   29.51%   29.51%   -0.01%     
==========================================
  Files        1440     1440              
  Lines      108541   108555      +14     
  Branches    41507    41509       +2     
==========================================
+ Hits        32034    32037       +3     
- Misses      73388    73398      +10     
- Partials     3119     3120       +1     
Flag Coverage Δ *Carryforward flag
differential 6.45% <0.00%> (?)
total 29.51% <ø> (ø) Carriedforward from 4e93960

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 42efae0 into autowarefoundation:main Nov 29, 2024
41 of 42 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-pe56 branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants