fix(autoware_utils): address self-intersecting polygons in random_concave_generator and handle empty inners() during triangulation #8995
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.05 (5.12 -> 5.07)
- Declining Code Health: 1 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional random_concave_polygon.cpp: random_concave_polygon
Annotations
Check notice on line 1 in common/autoware_universe_utils/src/geometry/ear_clipping.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.59 to 5.63, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 373 in common/autoware_universe_utils/src/geometry/random_concave_polygon.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
random_concave_polygon increases in cyclomatic complexity from 11 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 373 in common/autoware_universe_utils/src/geometry/random_concave_polygon.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
random_concave_polygon has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 1 in common/autoware_universe_utils/src/geometry/random_concave_polygon.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.73 to 4.80, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.50 to 4.57, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in common/autoware_universe_utils/test/src/geometry/test_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1898 to 1976, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.