Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused orocos kdl from dependencies #848

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 3, 2022

Description

The rosdep key of orocos_kdl has been renamed to orocos_kdl_vendor for rolling/humble in this PR.
orocos_kdl seems not to be used in autoware_auto_tf2, so I remove the dependecy to make rosdep install work.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from kenji-miyake May 3, 2022 22:58
@wep21 wep21 enabled auto-merge (squash) May 3, 2022 23:03
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #848 (ec49186) into main (20c6dd4) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #848   +/-   ##
=====================================
  Coverage   9.58%   9.58%           
=====================================
  Files        925     925           
  Lines      57411   57411           
  Branches    6863    6863           
=====================================
  Hits        5504    5504           
  Misses     47384   47384           
  Partials    4523    4523           
Flag Coverage Δ *Carryforward flag
differential 50.29% <ø> (?)
total 9.58% <ø> (ø) Carriedforward from 20c6dd4

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c6dd4...ec49186. Read the comment docs.

@wep21 wep21 merged commit b0dcc90 into main May 3, 2022
@wep21 wep21 deleted the remove-orocos-kdl branch May 3, 2022 23:18
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
wep21 referenced this pull request in tier4/autoware.universe Dec 12, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
h-ohta referenced this pull request in tier4/autoware.universe May 11, 2023
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
v-sugahara7993-esol referenced this pull request in tier4/autoware.universe May 11, 2023
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
v-sugahara7993-esol referenced this pull request in tier4/autoware.universe May 11, 2023
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
h-ohta referenced this pull request in tier4/autoware.universe May 12, 2023
* fix: remove unused orocos kdl from dependencies (#848)

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix(ci): fix action for Humble

---------

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 3, 2023
…lustering_pipeline

refactor(perception): rearrange clustering pipeline (autowarefoundation#4999)
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…ation#848)

update param

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants