Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_diagnostics): add package name prefix of autoware_ #8130

Conversation

technolojin
Copy link
Contributor

Description

This PR adds the autoware_ prefix to the package name.

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested on a local environment. Same method as #7915

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin marked this pull request as ready for review July 22, 2024 08:35
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 22, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 22, 2024
@technolojin technolojin enabled auto-merge (squash) July 22, 2024 08:42
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (64a1658) to head (2bad99c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8130      +/-   ##
==========================================
- Coverage   29.13%   29.09%   -0.05%     
==========================================
  Files        1610     1612       +2     
  Lines      118117   118280     +163     
  Branches    50842    50863      +21     
==========================================
- Hits        34418    34416       -2     
- Misses      74481    74646     +165     
  Partials     9218     9218              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.13% <ø> (-0.01%) ⬇️ Carriedforward from 86b39a2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit c3bf28c into autowarefoundation:main Jul 22, 2024
37 of 39 checks passed
@technolojin technolojin deleted the refactor/prefix-image_diagnostics branch July 23, 2024 00:43
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…towarefoundation#8130)

* refactor: rename image_diagnostics to autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/image_diagnostics to sensing/autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 23, 2024
…towarefoundation#8130)

* refactor: rename image_diagnostics to autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/image_diagnostics to sensing/autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jul 23, 2024
…towarefoundation#8130)

* refactor: rename image_diagnostics to autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/image_diagnostics to sensing/autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…towarefoundation#8130)

* refactor: rename image_diagnostics to autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename sensing/image_diagnostics to sensing/autoware_image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants