Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_diagnostics): fix namespace and directory structure #7915

Conversation

technolojin
Copy link
Contributor

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment.

# terminal 1
ros2 launch image_transport_decompressor image_transport_decompressor.launch.xml \
input_topic_name:=/sensing/camera/camera0/image_rect_color/compressed \
output_topic_name:=/sensing/camera/camera0/image_rect_color

# terminal 2
ros2 launch image_diagnostics image_diagnostics_node.launch.xml input_topic_name:=/sensing/camera/camera0/image_rect_color

# terminal 3: 
# play a bagfile contains '/sensing/camera/camera0/image_rect_color/compressed'

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
@technolojin technolojin marked this pull request as ready for review July 9, 2024 08:12
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.44%. Comparing base (6d0247e) to head (7c1a6a8).
Report is 3 commits behind head on main.

Files Patch % Lines
...g/image_diagnostics/src/image_diagnostics_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7915      +/-   ##
==========================================
- Coverage   28.44%   28.44%   -0.01%     
==========================================
  Files        1591     1592       +1     
  Lines      116213   116221       +8     
  Branches    49613    49616       +3     
==========================================
  Hits        33059    33059              
- Misses      74141    74149       +8     
  Partials     9013     9013              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.44% <ø> (+<0.01%) ⬆️ Carriedforward from 6d0247e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 9c559e6 into autowarefoundation:main Jul 10, 2024
38 of 39 checks passed
@technolojin technolojin deleted the refactor/namespace-image_diagnostics branch July 10, 2024 01:50
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…utowarefoundation#7915)

refactor: update include paths and namespace for image_diagnostics

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants