fix(detected_object_validation): add virtual destructor to obstacle_pointcloud_based_validator #7761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bstacle_pointcloud_based_validator Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki
requested review from
badai-nguyen,
Shin-kyoto,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7761 +/- ##
==========================================
- Coverage 28.36% 28.36% -0.01%
==========================================
Files 1584 1584
Lines 115529 115541 +12
Branches 49251 49254 +3
==========================================
Hits 32773 32773
- Misses 73812 73824 +12
Partials 8944 8944
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yhisaki
changed the title
yhisaki
force-pushed
the
add-virtual-destructor-to-obstacle_pointcloud_based_validator
branch
from
754c228 to
cb05bc7
Compare
…d_based_validator
yhisaki
deleted the
add-virtual-destructor-to-obstacle_pointcloud_based_validator
branch
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…ointcloud_based_validator (autowarefoundation#7761) fix(obstacle_pointcloud_based_validator): add virtual destructor to obstacle_pointcloud_based_validator Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…ointcloud_based_validator (autowarefoundation#7761) fix(obstacle_pointcloud_based_validator): add virtual destructor to obstacle_pointcloud_based_validator Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ointcloud_based_validator (#7761) fix(obstacle_pointcloud_based_validator): add virtual destructor to obstacle_pointcloud_based_validator Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…ointcloud_based_validator (autowarefoundation#7761) fix(obstacle_pointcloud_based_validator): add virtual destructor to obstacle_pointcloud_based_validator Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
https://stackoverflow.com/questions/461203/when-to-use-virtual-destructors
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.