Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detected_object_validation): add virtual destructor to obstacle_pointcloud_based_validator #7761

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(detected_object_validation): add virtual destructor to obstacle_pointcloud_based_validator #7761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb05bc7
fix(obstacle_pointcloud_based_validator): add virtual destructor to o…
yhisaki Jul 1, 2024
7534f14
Merge branch 'main' into add-virtual-destructor-to-obstacle_pointclou…
yhisaki Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ation/include/detected_object_validation/obstacle_pointcloud_based_validator/debugger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
#include <pcl/point_types.h>
#include <pcl_conversions/pcl_conversions.h>

#include <memory>
#include <vector>

namespace obstacle_pointcloud_based_validator
{
class Debugger
Expand Down
2 changes: 2 additions & 0 deletions ...ct_validation/obstacle_pointcloud_based_validator/obstacle_pointcloud_based_validator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@
const autoware_perception_msgs::msg::DetectedObject & object) = 0;
size_t getThresholdPointCloud(const autoware_perception_msgs::msg::DetectedObject & object);
virtual pcl::PointCloud<pcl::PointXYZ>::Ptr getDebugNeighborPointCloud() = 0;

virtual ~Validator() = default;

Check warning on line 79 in perception/detected_object_validation/include/detected_object_validation/obstacle_pointcloud_based_validator/obstacle_pointcloud_based_validator.hpp

View check run for this annotation

Codecov / codecov/patch

perception/detected_object_validation/include/detected_object_validation/obstacle_pointcloud_based_validator/obstacle_pointcloud_based_validator.hpp#L79 

Added line #L79 was not covered by tests
};

class Validator2D : public Validator
Expand Down
Loading