-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build-and-test-differential): use github runner #6278
ci(build-and-test-differential): use github runner #6278
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM because Github Actions perfomance was improved.
https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/
…oundation#6278)" This reverts commit 0262c68.
…utowarefoundation#6278)" (autowarefoundation#6306) * Revert "ci(build-and-test-differential): remove prevent-no-label-execution (autowarefoundation#6292)" This reverts commit 76cc954. * Revert "ci(build-and-test-differential): use github runner (autowarefoundation#6278)" This reverts commit 0262c68.
…utowarefoundation#6278)" (autowarefoundation#6306) * Revert "ci(build-and-test-differential): remove prevent-no-label-execution (autowarefoundation#6292)" This reverts commit 76cc954. * Revert "ci(build-and-test-differential): use github runner (autowarefoundation#6278)" This reverts commit 0262c68.
@kminoda it's better to run @mitsudome-r this was never supposed to be merged because even in the PR description, the available space is The available space for public runners was always this size. This PR was merged, worked a couple of times randomly. Because by nature, the build and test differential workflow can build varying count of packages, changing the size footprint. And the container size was another blocker, sometimes preventing the job from starting in the first place. As for the updated workflow: from the latest job:
The available space for the containers is still the same. |
I've also browsed some passing jobs that has passed from this PR's merge. Without CUDA
With CUDA
It seems you got some |
…n#6278) * ci(build-and-test-differential): use github runner Signed-off-by: kminoda <koji.minoda@tier4.jp> * change clang-tidy runner Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp>
…utowarefoundation#6278)" (autowarefoundation#6306) * Revert "ci(build-and-test-differential): remove prevent-no-label-execution (autowarefoundation#6292)" This reverts commit 76cc954. * Revert "ci(build-and-test-differential): use github runner (autowarefoundation#6278)" This reverts commit 0262c68.
Description
Use GitHub runner.
The runner has been changed as follows:
Apparently the disk image size has been reduced, and thus we would like to use GitHub Runner again, since current self-hosted runner based CI is too slow to execute multiple PRs.
Test run: https://github.com/HansRobo/autoware.universe/actions/runs/7736637727/job/21094318337
Remaining disk space:
du
results in the latest full-built Autoware:Tests performed
As shown above
Effects on system behavior
There is a risk in a near future that the CI will fail again due to the disk usage limit as it was before.
Autoware developers need to understand the importance of reducing the file size of both scripts and the generated binaries.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.