-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_projection_loader): rework parameters #6253
refactor(map_projection_loader): rework parameters #6253
Conversation
…param.yaml Added launch argument map_projection_loader_param_path to map.launch.xml Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Modified README.md of map_projection_loader to read the schema.json file to construct the table of parameters Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed checking the schema and confirming the operation in my environment. I will approve if you correct the typo.
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
…ikiYamada4/autoware.universe into refactor/map_projection_loader_params
I updated this branch to import #6278. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6253 +/- ##
==========================================
+ Coverage 14.38% 14.42% +0.03%
==========================================
Files 1907 1906 -1
Lines 129943 129570 -373
Branches 37616 37516 -100
==========================================
- Hits 18697 18686 -11
+ Misses 90237 89923 -314
+ Partials 21009 20961 -48
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…n#6253) * Extract all params in map_projection_loader to map_projection_loader.param.yaml Added launch argument map_projection_loader_param_path to map.launch.xml Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Added map_projection_loader.schema.json. Modified README.md of map_projection_loader to read the schema.json file to construct the table of parameters Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix * Fixed typo Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> --------- Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…n#6253) * Extract all params in map_projection_loader to map_projection_loader.param.yaml Added launch argument map_projection_loader_param_path to map.launch.xml Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Added map_projection_loader.schema.json. Modified README.md of map_projection_loader to read the schema.json file to construct the table of parameters Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix * Fixed typo Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> --------- Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
This PR must be merged with autowarefoundation/autoware_launch#839
Description
This PR has done three changes.
map_projection_loader.launch.xml
tomap_projection_loader.param.yaml
.map_projection_loader.schema.json
to validatemap_projection_loader.param.yaml
.README.md
to reflect ros parameters frommap_projection_loader.schema.json
.Tests performed
1. Passing ros parameters
I did the rosbag replay simulation tutorial and checked.
and got the follwoing result which is expected.
2. JSON validation
I did the following command at
autoware.universe/map/
and confirmed thatmap_projection_loader.schema.json
andmap_projection_loader.param.yaml
are OK.3. Write a table of ros parameters via
map_projection_loader.schema.json
I did
mkdocs serve
and confirmed that the table of ros parameters is constructed in the documents.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.