-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): use ec2 for build-and-test-differential #4413
Conversation
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
I've added a detailed description to the first post. |
After this is merged, I will probably remove this workflow from the sync-files job until we decide to increase its scope. Related PR: #4372 (comment) |
Fixed spell check failure in tier4/autoware-spell-check-dict#593. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
:( It cannot see the secret, now investigating it. |
I think this whole plan won't work. I will revert this change and add the machine for perpetual running. More info on why it was a bad idea: GitHub Actions requiring secrets on a fork-origin PR |
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
…n#4413) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
…oundation#4413)" (autowarefoundation#4477) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx How about using GitHub hosted larger runner? Maybe is it out of your budget?
|
@shmpwk In order to use larger GitHub hosted runners, we have to register the organization as either GitHub Team plan or GitHub Enterprise plan as explained here. However, if we upgrade AutowareFoundation's plan, then we have to pay at least $3.67 per user/month. We currently have 173 members added to the organization so that would be extra cost of about $7,600 per year. |
@shmpwk in addition to Github Team pricing, c6a.xlarge instance costs $0.153 per hour. For a month, |
…n#4413) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
…oundation#4413)" (autowarefoundation#4477) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
Description
How it works
There are 5 consequent jobs:
The way it works is,
1.
prevent-no-label-execution
This job checks if PR has
prevent-no-label-execution
tag. If yes, it can continue. If not, workflow stops.2.
start-runner
autowarefoundation/autoware.universe/runners
using my personal Github token (which is a secret).self-hosted, Linux, X64, o837y
(last one being unique)1m40s
to complete. This delay comes mostly from EC2 instantiating the machine.3.
build-and-test-differential
o837y
4.
clang-tidy-differential
build-and-test-differential
)o837y
5.
stop-runner
autowarefoundation/autoware.universe/runners
using the unique label that had been assigned.Summary
Tests performed
Job is successful: https://github.com/autowarefoundation/autoware.universe/actions/runs/5716141354/job/15487030009?pr=4413
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.