Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start_planner): visualize drivable lanes for shift path and pull_out_lanes for collision detection #6110

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 18, 2024

Description

visualize drivable lanes which is used for lane departure check with for shift pull out path with cyan color
image

visualize pull_out_lanes which is used for extracting static objects collision detection with pink color
image

image

image

Tests performed

test with psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 18, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/visualize_drivable_lanes_for_shift_path branch 2 times, most recently from 97ed099 to 9140499 Compare January 18, 2024 09:16
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Jan 23, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start_planmer): visualize drivable lanes for shift path refactor(start_planmer): visualize drivable lanes for shift path and pull_out_lanes for collision detection Jan 23, 2024
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Jan 23, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review January 23, 2024 06:11
@kyoichi-sugahara
Copy link
Contributor Author

@kosuke55

  • Change variable names from drivable_lanes to departure_check_lanes for variable name, function name and local variable name.
  • Add TODO of improving algorithm for lane departure chekcer in shift pull out
    Can you review the PR?

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (9313a4c) 14.93% compared to head (c0c3809) 14.37%.
Report is 22 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 23 Missing ⚠️
...r_path_start_planner_module/src/shift_pull_out.cpp 0.00% 3 Missing ⚠️
...avior_path_start_planner_module/shift_pull_out.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6110      +/-   ##
==========================================
- Coverage   14.93%   14.37%   -0.57%     
==========================================
  Files        1816     1906      +90     
  Lines      125113   130021    +4908     
  Branches    37615    37416     -199     
==========================================
+ Hits        18691    18694       +3     
- Misses      85410    90383    +4973     
+ Partials    21012    20944      -68     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.42% <ø> (-0.52%) ⬇️ Carriedforward from 8187cd7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start_planmer): visualize drivable lanes for shift path and pull_out_lanes for collision detection refactor(start_planner): visualize drivable lanes for shift path and pull_out_lanes for collision detection Jan 31, 2024
@kyoichi-sugahara kyoichi-sugahara removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

…shift_path

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/visualize_drivable_lanes_for_shift_path branch from 0762741 to c0c3809 Compare February 1, 2024 14:30
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
@kyoichi-sugahara kyoichi-sugahara merged commit cc266ea into autowarefoundation:main Feb 1, 2024
27 of 33 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/visualize_drivable_lanes_for_shift_path branch February 1, 2024 15:39
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…pull_out_lanes for collision detection (autowarefoundation#6110)

visualize drivable lanes for shift path and pull_out_lanes for collision detection

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…pull_out_lanes for collision detection (autowarefoundation#6110)

visualize drivable lanes for shift path and pull_out_lanes for collision detection

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants