refactor(side_shift): support new interface #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
component:planning
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5556 +/- ##
=======================================
Coverage 15.27% 15.27%
=======================================
Files 1713 1713
Lines 118160 118151 -9
Branches 37790 37787 -3
=======================================
Hits 18047 18047
+ Misses 79563 79554 -9
Partials 20550 20550
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 943fef0
Refactored and simplified the
SideShiftModuleclass for the behavior path planner. Removed unused functions, used base class functions, and renamed and changed the return type ofupdateStatefunction. Improved the functionality and readability of the side shift module.Tests performed
simplescreenrecorder-2023-11-11_14.50.25.mp4
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.