fix(mission_planner): revert "refactor(mission_planner): use combineLaneletsShape in lanele2_extension (#5535)" #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
isamu-takagi,
mitsudome-r,
TakaHoribe,
takayuki5168 and
purewater0901
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
run:build-and-test-differential
ismetatabay
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Sorry, I forgot the test it on neighbour lanelets: #5535. LGTM
|
sorry and thanks for the quick reply 🙇 |
takayuki5168
approved these changes
Nov 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
=======================================
Coverage 15.35% 15.36%
=======================================
Files 1697 1697
Lines 117455 117472 +17
Branches 37748 37762 +14
=======================================
+ Hits 18041 18048 +7
Misses 78873 78873
- Partials 20541 20551 +10
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…aneletsShape in lanele2_extension (autowarefoundation#5535)" (autowarefoundation#5543) Revert "refactor(mission_planner): use combineLaneletsShape in lanelet2_extension (autowarefoundation#5535)" This reverts commit c4ca645.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert (#5535)"
This reverts commit c4ca645.because of degradation
only
combine_laneletscan combine neighbor lanesDescription
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.